Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Edit Original" Pattern keeps Post MetaBoxes #64914

Closed
2 tasks done
MadtownLems opened this issue Aug 29, 2024 · 3 comments · Fixed by #64990
Closed
2 tasks done

"Edit Original" Pattern keeps Post MetaBoxes #64914

MadtownLems opened this issue Aug 29, 2024 · 3 comments · Fixed by #64990
Assignees
Labels
[Feature] Meta Boxes A draggable box shown on the post editing screen [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@MadtownLems
Copy link

Description

When writing a Page or Post, and clicking "Edit Original" on a synced pattern, the editor shifts into editing the Pattern, but metaboxes associated with the Post remain. This creates a very confusing screen, as it looks like the metaboxes are associated with the Pattern, when they shouldn't be.

Step-by-step reproduction instructions

  1. Insert a synced pattern onto a Post, while also using a plugin that has (legacy?) metaboxes.
  2. Click 'Edit Original' of the synced pattern.

Screenshots, screen recording, code snippet

For comparison, this is the screenshot of simply adding a new Pattern. Nice and clean!
new-pattern

However, when you Edit Original from editing a Post, you get this mess:
edit-inline

The metaboxes now all look associated with the Pattern (and will retain any values that had been set previously.)

Environment info

WordPress 6.6.1, no Gutenberg plugin.

Obviously I have not tested with all plugins deactivated, because I need them to create the metaboxes, but I checked the box because it's required. 🤷‍♂️

Please confirm that you have searched existing issues in the repo.

  • Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

  • Yes
@MadtownLems MadtownLems added the [Type] Bug An existing feature does not function as intended label Aug 29, 2024
@helenaartmann helenaartmann added the [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) label Aug 29, 2024
@t-hamano t-hamano added the [Feature] Meta Boxes A draggable box shown on the post editing screen label Aug 30, 2024
@lgladdy
Copy link

lgladdy commented Aug 30, 2024

You can easily test this by having an ACF field group associated with a post, then edit the synced pattern.

It looks like the legacy backcompat metabox layer isn't removed when you drop into the pattern editor.

@ericdye
Copy link

ericdye commented Sep 2, 2024

I would also add that if there is more content within the pattern or more meta boxes, the synced pattern content is "covered" and cannot be edited in any way. My most recent report from a Newspack user expected there to be a scrollbar, but there is not.

@smerriman
Copy link

This has been an open issue since July: #63143

Hopefully this one gets more traction than that, as it hasn't been resolved in 6.6.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Meta Boxes A draggable box shown on the post editing screen [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

7 participants