Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataViews: focus lost when removing the last filter #64697

Closed
oandregal opened this issue Aug 21, 2024 · 1 comment · Fixed by #67003
Closed

DataViews: focus lost when removing the last filter #64697

oandregal opened this issue Aug 21, 2024 · 1 comment · Fixed by #67003
Assignees
@ntsekouras
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] DataViews /packages/dataviews [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@oandregal
Copy link
Member

oandregal commented Aug 21, 2024 •
edited
Loading

Description

Using the keyboard, when the last filter of DataViews is removed, the focus is lost.

Step-by-step reproduction instructions

A video with the steps:

Gravacao.do.ecra.2024-08-21.as.22.05.05.mov

What I expected instead

That the Filter Toggle gained the focus back.
@oandregal oandregal added the [Type] Bug An existing feature does not function as intended label Aug 21, 2024
@oandregal oandregal self-assigned this Aug 21, 2024
@oandregal oandregal added the [Package] DataViews /packages/dataviews label Aug 21, 2024
@oandregal oandregal removed their assignment Aug 21, 2024
@oandregal oandregal mentioned this issue Aug 21, 2024
Merged
@jameskoster
Copy link
Contributor

What I expected instead
That the Filter Toggle gained the focus back.

Agreed.

@mtias mtias added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label Aug 31, 2024
@ntsekouras ntsekouras mentioned this issue Nov 14, 2024
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ntsekouras ntsekouras

Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] DataViews /packages/dataviews [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

DataViews: Fix focus loss when removing all filters or resetting WordPress/gutenberg
4 participants
@mtias @oandregal @jameskoster @ntsekouras