Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Block: WordPress Embed #644

Closed
mapk opened this issue May 4, 2017 · 2 comments
Closed

Add Block: WordPress Embed #644

mapk opened this issue May 4, 2017 · 2 comments
Assignees
@kopepasah
Labels
[Feature] Blocks Overall functionality of blocks General Interface Parts of the UI which don't fall neatly under other labels. [Type] Task Issues or PRs that have been broken down into an individual action to take
Milestone
Beta

Comments

@mapk
Copy link
Contributor

mapk commented May 4, 2017

Looking at the WordPress Embed block. If we keep a similar design to what is currently active in Core, we can create a block that should look something like this. Let's discuss.

Also to note, the block automatically takes this design as soon as the Editor realizes this URL is for another WP site. As soon as a URL is pasted into the block, it converts to this layout.

Neutral:
wordpress embed-neutral

Hover:
wordpress embed-hover

Selected
wordpress embed-selected

User click to embed on own site:
wordpress embed-embed
@jasmussen jasmussen added [Feature] Blocks Overall functionality of blocks General Interface Parts of the UI which don't fall neatly under other labels. labels May 4, 2017
@mtias mtias added the [Type] Task Issues or PRs that have been broken down into an individual action to take label May 4, 2017
@kopepasah
Copy link
Member

If no one is working on this, I will take it over.

@kopepasah kopepasah self-assigned this May 9, 2017
@jasmussen jasmussen added this to the Beta milestone May 10, 2017
@jasmussen
Copy link
Contributor

I'm closing this in favor of #1034, and because the embed block as inspired by this is in!

@Verdinjoshua26 Verdinjoshua26 mentioned this issue Nov 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kopepasah kopepasah

Labels
[Feature] Blocks Overall functionality of blocks General Interface Parts of the UI which don't fall neatly under other labels. [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Milestone
Beta
Development

No branches or pull requests
4 participants
@mtias @mapk @kopepasah @jasmussen