Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image Block: Allow drop-to-replace for existing image blocks #6424

Closed
shaunandrews opened this issue Apr 25, 2018 · 6 comments
Closed

Image Block: Allow drop-to-replace for existing image blocks #6424

shaunandrews opened this issue Apr 25, 2018 · 6 comments
Labels
[Feature] Drag and Drop Drag and drop functionality when working with blocks [Feature] Media Anything that impacts the experience of managing media Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Milestone

Comments

@shaunandrews
Copy link
Contributor

Issue Overview

I'm working up the layout for a page, I duplicated a set of blocks with an image on the left and some text on the right. My hope was that I could just drop images from my desktop to replace the duplicated image blocks, but it doesn't work.

Steps to Reproduce

  1. Add an image block and choose an image
  2. Drag an image from your desktop overtop of the image block added in step 1.
  3. Notice that you can't replace the existing image, but rather add a new image.

Safari (Version 11.1)

Expected Behavior

I expected that I could drop an image on top of an existing image block and replace that image. Here's how it works in Keynote:

keynote-drop-image

Current Behavior

Right now its all sorts of wonky, here's a gif of what I experienced:
image-drop-to-upload

Since I have the existing image block set to left align, the inserter around the text blocks activates and tries to get me to add a new image block. You'll also notice that there's some weird white text appearing when holding an image over the editor canvas.

If I drop the image, I get some really messed up stuff:

screen shot 2018-04-25 at 11 53 17 am

@shaunandrews
Copy link
Contributor Author

Another thought here: Maybe dropping an image on an existing image should create a gallery? I'm not sure thats what I'd expect, but I could see the gallery transformation being (maybe) more useful and common than replacing an image.

@karmatosed
Copy link
Member

Oh that's a good idea! I think that having if you place an image on another if it became a gallery this would be what someone would expect.

Marking as enhancement as it is but this could be really nice and a moment of delight for a user.

@karmatosed karmatosed added [Type] Enhancement A suggestion for improvement. [Feature] Media Anything that impacts the experience of managing media labels Apr 26, 2018
@shaunandrews
Copy link
Contributor Author

Maybe even something like this when someone first drops an image on an existing image block:

slice

@karmatosed
Copy link
Member

🤔 my initial thoughts are against an option here but we are making an assumption so need to check if that is a good idea or not. I'd not be against this until we knew at least which was the most common wanted.

@oandregal oandregal added the [Feature] Drag and Drop Drag and drop functionality when working with blocks label Sep 6, 2018
@mtias mtias added this to the Future: 5.1 milestone Nov 21, 2018
@richtabor richtabor added the Needs Design Feedback Needs general design feedback. label Jun 12, 2020
@richtabor
Copy link
Member

Is this still relevant?

@paaljoachim
Copy link
Contributor

I just tested.
This works in version 13.11 of Safari on my Mac running OSX 10.15.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Drag and Drop Drag and drop functionality when working with blocks [Feature] Media Anything that impacts the experience of managing media Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

6 participants