Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grid: Add max to 'Row span' and 'Column span' controls #63967

Open
noisysocks opened this issue Jul 26, 2024 · 1 comment · May be fixed by #64895
Open

Grid: Add max to 'Row span' and 'Column span' controls #63967

noisysocks opened this issue Jul 26, 2024 · 1 comment · May be fixed by #64895
Labels
[Feature] Layout Layout block support, its UI controls, and style output. [Status] In Progress Tracking issues with work in progress [Type] Task Issues or PRs that have been broken down into an individual action to take

Comments

@noisysocks
Copy link
Member

noisysocks commented Jul 26, 2024 •
edited
Loading

Feedback from @jameskoster:

It feels a bit unexpected that I can set row span to a greater number than the actual number of rows in the grid, especially in auto mode. In manual mode should it increase the row value on the parent?

We have a max on the <input> for the Row and Column controls so I think a sensible fix here would be to similarly set a max on the Row span and Column span controls.

The max needs to take into account the position of the grid item. For example if a grid item is in the second last column then its max column span should be 2.

It might be nice to have these controls automatically increase the parent grid's size one day but for now I think the important thing is that we're consistent across all of the grid controls. Right now the placement controls have a max but the span controls don't—weird!
@noisysocks noisysocks added [Type] Bug An existing feature does not function as intended [Feature] Layout Layout block support, its UI controls, and style output. labels Jul 26, 2024
@noisysocks noisysocks mentioned this issue Jul 26, 2024
Open
37 tasks
@noisysocks noisysocks changed the title Grid: Row span and Column span inputs don't have a max value Grid: Add max to _Row span_ and _Column span_ controls Jul 26, 2024
@noisysocks noisysocks changed the title Grid: Add max to _Row span_ and _Column span_ controls Grid: Add max to 'Row span' and 'Column span' controls Jul 26, 2024
@noisysocks noisysocks added [Type] Task Issues or PRs that have been broken down into an individual action to take and removed [Type] Bug An existing feature does not function as intended labels Jul 26, 2024
@vipul0425 vipul0425 linked a pull request Aug 29, 2024 that will close this issue
Open
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Aug 29, 2024
@vipul0425
Copy link
Contributor

Hi @noisysocks I have raised a PR for this. Let me know if you have any suggestions.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Layout Layout block support, its UI controls, and style output. [Status] In Progress Tracking issues with work in progress [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat: Adds max limit to row span and column span in grid. vipul0425/gutenberg
2 participants
@noisysocks @vipul0425