Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Featured Image label missing after image has been added to page #63321

Open
andreawetzel opened this issue Jul 9, 2024 · 7 comments · May be fixed by #63344
Open

Featured Image label missing after image has been added to page #63321

andreawetzel opened this issue Jul 9, 2024 · 7 comments · May be fixed by #63344
Labels
[Feature] Document Settings Document settings experience [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Design Feedback Needs general design feedback. [Type] Bug An existing feature does not function as intended

Comments

@andreawetzel
Copy link

Description

Testing 6.6-rc3. After adding a featured image, there is no longer a label above the image stating that it is a Featured Image.

The concern is that someone with little WordPress Experience may inherit a site that has featured images in place and will have no context for what this image is for and how it is related to the page or post. It is also a potential accessibility barrier to not have visual context related to this form input.

Step-by-step reproduction instructions

  1. Open or create a page
  2. Add or upload a featured image

Screenshots, screen recording, code snippet

featured-image-no-label

Environment info

WP 6.6-rc3
Twenty TwentyFour theme
Gutenberg plugin not enabled

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@andreawetzel andreawetzel added the [Type] Bug An existing feature does not function as intended label Jul 9, 2024
@Mamaduka Mamaduka added [Feature] Document Settings Document settings experience Needs Design Feedback Needs general design feedback. labels Jul 9, 2024
@Mamaduka
Copy link
Member

cc @jameskoster, @ntsekouras

@afercia afercia added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label Jul 10, 2024
@afercia
Copy link
Contributor

afercia commented Jul 10, 2024

I support adding headings to identify sections of content. The 'label' shouldn't just be a visual label i.e. unsemantic text. It should be a heading element.

The effort to reunify the Post Editor with the Site Editor and the new Post Summary panel introduced many changes and an overall drop in the amount of headings used on the page.

In the screenshot below, a comparison of the headings structure in WordPress 6.5 (left) and the one on trunk (right).
Overall, I wouldn't say the content structure and headings hierarchy has improved, to be fair.

post panel and headings

I'd like to remind everyone that headings are of fundamental importance for many users to navigate the page and find content.

@jameskoster
Copy link
Contributor

I assume we'd also need headings for the other sections (Summary and Excerpt)?

Screenshot 2024-07-10 at 15 50 08

cc @WordPress/gutenberg-design for input.

@afercia
Copy link
Contributor

afercia commented Jul 10, 2024

I assume we'd also need headings for the other sections (Summary and Excerpt)?

Ideally, yes but not sure that it should be discussed in the scope of this issue, which is specific to the featured image.

To me, the new Post Summary mixes together settings that are conceptually very different. I'd argue that also from a visual perspecitve, this panel is now a litlte too 'crowded'. Scanning visually its content is now more challenging. This is a broader issue though and there are other things to address e.g.:

  • Two H1 headings in the same page
  • A H1 and a H2 with the same text (the post title)
  • The post title is displayed three times on the page, which is maybe a little too many times?
    1. In the document bar
    2. In the post title field.
    3. In the Post Summary card
  • The post settings panel doesn't have a heading that tells uses what it is about e.g. 'Post settings'.
  • The verse icon should not be used for hte post title, see The post title shown in the editor UI should not use the Verse block icon #62186

@youknowriad
Copy link
Contributor

Personally, I felt that the new design improved the readability of the sidebar as it became way easier to scan. The old one had way too much information at the same time for my liking and it was also very disorganized. The new one seems more consistent.

There might be some things we can do to improve clarity though but I do appreciate the consistency and the clarity of the new design.

Just my 2cts

@afercia
Copy link
Contributor

afercia commented Jul 11, 2024

Besides personal perception and opinions, an UI that aims to be as accessible as possible must provide information. Removing headings or other informative text isn't a great way to improve information. It justs makes the UI visually lighter.

An accessible UI should prioritize function over form. Which is, I guess, the point where views about design differ between designers and accessibility specialists.

@youknowriad
Copy link
Contributor

An accessible UI should prioritize function over form.

This is exactly where I'm coming from when I shared the above. It's not about form, it's about the UI being more usable IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Document Settings Document settings experience [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Design Feedback Needs general design feedback. [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants