Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

English strings inserted in translations #6246

Closed
chantalcoolsma opened this issue Apr 18, 2018 · 5 comments
Closed

English strings inserted in translations #6246

chantalcoolsma opened this issue Apr 18, 2018 · 5 comments
Labels
Internationalization (i18n) Issues or PRs related to internationalization efforts [Type] Bug An existing feature does not function as intended

Comments

@chantalcoolsma
Copy link

On translate.wordpress.org there is this string:

https://translate.wordpress.org/projects/wp-plugins/gutenberg/dev/nl/default?filters%5Bstatus%5D=either&filters%5Boriginal_id%5D=5746763&filters%5Btranslation_id%5D=54835322

For Dutch this is translated as 'Voeg %s toe'. The %s shows English words. Results in for example:

'Voeg Image toe' or
'Voeg Gallery toe' or
'Voeg Heading toe'

schermafbeelding 2018-04-18 om 16 06 55

schermafbeelding 2018-04-18 om 16 07 03

I guess the '%s' strings need to be translatable too.

@Soean Soean added [Type] Bug An existing feature does not function as intended Internationalization (i18n) Issues or PRs related to internationalization efforts labels Apr 18, 2018
@Soean
Copy link
Member

Soean commented Apr 18, 2018

bildschirmfoto 2018-04-19 um 01 25 47

I can't reproduce it. Seems to be fixed in Gutenberg 2.7. Please reopen if it still exists.

@Soean Soean closed this as completed Apr 18, 2018
@chantalcoolsma
Copy link
Author

@Soean yes, I noticed it has been changed in 2.7. However words like "Kop" (as shown in your example) shouldn't start with a capital. So "Kop" should be "kop" in this case. I noticed those are separate strings to translate, but since they are single words, translators translate them with a capital. I don't know if those strings are used anywhere else. Otherwise we could translate them without capitalisation. I can imagine this can also apply to other languages than Dutch.

Any ideas?

@rianrietveld
Copy link
Member

rianrietveld commented Apr 19, 2018

This seems a valid issue, worth to continue the discussion and find a solution for.

@rianrietveld rianrietveld reopened this Apr 19, 2018
@Soean
Copy link
Member

Soean commented Apr 19, 2018

@chantalcoolsma Thanks for your feedback. Thats another issue, different from the title and description, so I think it's better if we open a new issue.

@chantalcoolsma
Copy link
Author

@Soean I will open a generic localisation issue and reference this issue. Maybe other translators will drop their thoughts too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internationalization (i18n) Issues or PRs related to internationalization efforts [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

3 participants