Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Interactivity Router API to TypeScript #61371

Closed
abhi3315 opened this issue May 3, 2024 · 1 comment · Fixed by #61730
Closed

Refactor Interactivity Router API to TypeScript #61371

abhi3315 opened this issue May 3, 2024 · 1 comment · Fixed by #61730
Labels
Developer Experience Ideas about improving block and theme developer experience [Feature] Interactivity API API to add frontend interactivity to blocks. [Type] Code Quality Issues or PRs that relate to code quality

Comments

@abhi3315
Copy link
Contributor

abhi3315 commented May 3, 2024

What problem does this address?

The current code of the interactivity-router package is written in JavaScript. It should be written in TypeScript.

What is your proposed solution?

Refactor the files from JavaScript to TypeScript. There are following files that has to be refactored:

  • index.js
  • head.js
@abhi3315 abhi3315 added the [Type] Enhancement A suggestion for improvement. label May 3, 2024
@jordesign jordesign added the [Feature] Interactivity API API to add frontend interactivity to blocks. label May 5, 2024
@cbravobernal cbravobernal mentioned this issue May 7, 2024
Closed
@gziolo gziolo added [Type] Code Quality Issues or PRs that relate to code quality Developer Experience Ideas about improving block and theme developer experience and removed [Type] Enhancement A suggestion for improvement. labels May 10, 2024
@michalczaplinski michalczaplinski mentioned this issue May 16, 2024
Merged
@cbravobernal
Copy link
Contributor

Done in #61730

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Developer Experience Ideas about improving block and theme developer experience [Feature] Interactivity API API to add frontend interactivity to blocks. [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Interactivity API : Refactor interactivity-router to TS WordPress/gutenberg
4 participants
@gziolo @jordesign @cbravobernal @abhi3315