-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data views: Make filter reset button contextual to the view #60472
Comments
This comment was marked as outdated.
This comment was marked as outdated.
Responded here as well, I find it confusing to see a filter chip simpy by choosing a main navigation item. I would expect main navigation items to be preset views not ephemeral filters. |
This comment was marked as outdated.
This comment was marked as outdated.
Out of the discussion in #60468 it emerged that this is probably the way to go. |
#65264 will close this by introducing the concept of "locked view filters" — those are invisible to the user, so the reset button still behaves predictably to them (removes all visible filters). |
I think this is fixed now. If you add filters to the Trash view, then click Reset, you no longer see all pages. |
Closely related to #60468.
When you browse a view like "Trash" in page management the "Reset" button in the filter UI is visible by default, and clicking it will remove all filters.
Technically this is more like a "Remove" behavior, which in this context makes the "Reset" label a bit misleading.
Instead, we might consider making the filter reset action contextual. IE when you navigate to the Trash view, the "Reset" button is hidden/disabled, and only becomes active when you add/edit any filters. Clicking it would restore the view to its initial filter configuration, IE status filter active and
trash
selected.cc @WordPress/gutenberg-design @ntsekouras @oandregal for thoughts.
The text was updated successfully, but these errors were encountered: