Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data views: Make filter reset button contextual to the view #60472

Closed
jameskoster opened this issue Apr 4, 2024 · 6 comments
Closed

Data views: Make filter reset button contextual to the view #60472

jameskoster opened this issue Apr 4, 2024 · 6 comments
Labels
[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.

Comments

@jameskoster
Copy link
Contributor

Closely related to #60468.

When you browse a view like "Trash" in page management the "Reset" button in the filter UI is visible by default, and clicking it will remove all filters.

Technically this is more like a "Remove" behavior, which in this context makes the "Reset" label a bit misleading.

Instead, we might consider making the filter reset action contextual. IE when you navigate to the Trash view, the "Reset" button is hidden/disabled, and only becomes active when you add/edit any filters. Clicking it would restore the view to its initial filter configuration, IE status filter active and trash selected.

cc @WordPress/gutenberg-design @ntsekouras @oandregal for thoughts.

@jameskoster jameskoster added [Type] Enhancement A suggestion for improvement. Needs Design Feedback Needs general design feedback. [Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond labels Apr 4, 2024
@SaxonF

This comment was marked as outdated.

@jasmussen
Copy link
Contributor

Responded here as well, I find it confusing to see a filter chip simpy by choosing a main navigation item. I would expect main navigation items to be preset views not ephemeral filters.

@jameskoster

This comment was marked as outdated.

@jameskoster
Copy link
Contributor Author

Out of the discussion in #60468 it emerged that this is probably the way to go.

@jameskoster jameskoster changed the title Data views: Consider making filter reset button contextual to the view Data views: Make filter reset button contextual to the view Apr 16, 2024
@jameskoster jameskoster added Needs Dev Ready for, and needs developer efforts and removed Needs Design Feedback Needs general design feedback. labels Apr 16, 2024
@jasmussen jasmussen moved this from Next to Needs Dev in Design priorities Aug 27, 2024
@oandregal
Copy link
Member

#65264 will close this by introducing the concept of "locked view filters" — those are invisible to the user, so the reset button still behaves predictably to them (removes all visible filters).

@jameskoster
Copy link
Contributor Author

I think this is fixed now. If you add filters to the Trash view, then click Reset, you no longer see all pages.

@github-project-automation github-project-automation bot moved this from Needs Dev to Done in Design priorities Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants