Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MediaReplaceFlow: layout regression #58593

Closed
t-hamano opened this issue Feb 2, 2024 · 0 comments · Fixed by #58621
Closed

MediaReplaceFlow: layout regression #58593

t-hamano opened this issue Feb 2, 2024 · 0 comments · Fixed by #58621
Assignees
Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Feature] Media Anything that impacts the experience of managing media [Status] In Progress Tracking issues with work in progress [Type] Regression Related to a regression in the latest release

Comments

@t-hamano
Copy link
Contributor

t-hamano commented Feb 2, 2024

Description

It appears that recent changes made in the LinkControl component have caused a regression in the layout of the MediaReplaceFlow component.

As far as I researched, the two PRs, #57775 and #57608, are related.


⚒️ Before #57775 is merged

commit_27fc84e0

This should be the expected layout.


⚠️ After #57775 was merged

commit_614e0355

  • The icon and URL are misaligned.
  • The background color of the icon may also not be what we intended.
  • Also, this may be a Windows OS-specific problem, but the text descender is cut off.

✅ After #57608 was merged

Fixed by #58597

image

  • A scroll bar will appear.

These changes are in the Gutenberg version that ships to WP6.5, and I think they need to be fixed, so I'll add them to the editor task for WP6.5.

Step-by-step reproduction instructions

  • Insert an Image block
  • Add media.
  • Click "Replace" button.
@t-hamano t-hamano added [Feature] Media Anything that impacts the experience of managing media [Type] Regression Related to a regression in the latest release [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) labels Feb 2, 2024
@t-hamano t-hamano moved this to ❓ Triage in WordPress 6.5 Editor Tasks Feb 2, 2024
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Feb 2, 2024
@t-hamano t-hamano moved this from ❓ Triage to 🏗️ In Progress in WordPress 6.5 Editor Tasks Feb 3, 2024
@t-hamano t-hamano moved this from 🏗️ In Progress to 🔎 Needs Review in WordPress 6.5 Editor Tasks Feb 3, 2024
@github-project-automation github-project-automation bot moved this from 🔎 Needs Review to ✅ Done in WordPress 6.5 Editor Tasks Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Feature] Media Anything that impacts the experience of managing media [Status] In Progress Tracking issues with work in progress [Type] Regression Related to a regression in the latest release
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants