Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip: consider adding support for rendering in legacy popover slot #56420

Open
ciampo opened this issue Nov 22, 2023 · 1 comment
Open

Tooltip: consider adding support for rendering in legacy popover slot #56420

ciampo opened this issue Nov 22, 2023 · 1 comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Components /packages/components

Comments

@ciampo
Copy link
Contributor

ciampo commented Nov 22, 2023

As noted in #47614 (comment), the recent refactor of Tooltip introduced a change to where the tooltip's contents render in the page.

Prior to the refactor, Tooltip was using Popover internally, and as a consequence, the tooltip's contents were rendered inside the matching <Popover.Slot />.

After the refactor, the tooltip's contents render in a new dom node added by ariakit.

As a consequence, we should understand:

@ciampo ciampo added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Components /packages/components labels Nov 22, 2023
@ciampo
Copy link
Contributor Author

ciampo commented Nov 23, 2023

As per #56482, we should NOT have the Tooltip component render in the Popover.Slot by default.

At most, we could expose the portal and portalElement props to allow users to customize which DOM node should the tooltip render in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Components /packages/components
Projects
None yet
Development

No branches or pull requests

1 participant