Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Font Library: Port fixes to special characters on font faces from Create Block Theme #56184

Closed
vcanales opened this issue Nov 16, 2023 · 1 comment
Closed

Font Library: Port fixes to special characters on font faces from Create Block Theme #56184

vcanales opened this issue Nov 16, 2023 · 1 comment
Assignees
@vcanales
Labels
[Feature] Typography Font and typography-related issues and PRs [Type] Enhancement A suggestion for improvement.

Comments

@vcanales
Copy link
Member

vcanales commented Nov 16, 2023 •
edited
Loading

  • Font Family Name Quotation: Add single quotes to font family names in order to avoid errors related to trying to parse font names with special characters, white spaces, or numbers.

  • Non-Alphanumeric Character Check: It also checks if the font family name of a font being uploaded includes non-alphanumeric characters. If such characters are present, the form is invalidated.

Related to WordPress/create-block-theme#476
@vcanales vcanales added the [Feature] Typography Font and typography-related issues and PRs label Nov 16, 2023
@vcanales vcanales changed the title Port fixes to special characters on font faces to Gutenberg Font Library: Port fixes to special characters on font faces from Create Block Theme Nov 16, 2023
@vcanales vcanales self-assigned this Nov 16, 2023
@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Nov 16, 2023
@vcanales
Copy link
Member Author

vcanales commented Dec 5, 2023

Issues present in CBT are not relevant to the Font Library in Gutenberg.

@vcanales vcanales closed this as completed Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vcanales vcanales

Labels
[Feature] Typography Font and typography-related issues and PRs [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vcanales @jordesign