Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List block: Support block gap #55702

Closed
dkjensen opened this issue Oct 30, 2023 · 4 comments · Fixed by #55874
Closed

List block: Support block gap #55702

dkjensen opened this issue Oct 30, 2023 · 4 comments · Fixed by #55874
Assignees
@valerogarte
Labels
[Block] List Affects the List Block Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Enhancement A suggestion for improvement.

Comments

@dkjensen
Copy link

dkjensen commented Oct 30, 2023 •
edited
Loading

What problem does this address?

Controlling the spacing / gap between list items within a list block is not currently supported.

What is your proposed solution?

Add support for the blockGap on the list block
@jordesign jordesign added [Type] Enhancement A suggestion for improvement. [Block] List Affects the List Block labels Oct 31, 2023
@cbravobernal cbravobernal added the Good First Issue An issue that's suitable for someone looking to contribute for the first time label Nov 4, 2023
@cbravobernal cbravobernal self-assigned this Nov 4, 2023
@cbravobernal
Copy link
Contributor

cbravobernal commented Nov 4, 2023 •
edited
Loading

I just self-assigned for WordCamp Madrid Contributor's day. In case we cannot fix it. I will leave it for anyone on Monday 6th of November.

@valerogarte valerogarte mentioned this issue Nov 5, 2023
Merged
@valerogarte
Copy link
Contributor

This is my first PR in WP, after spent the day at the WordCamp Madrid Contributor's day.
However, I added the functionality in the PR, but once the pull request is launched it asks me to enter a tag, but it seems I don't have permissions to do it (or i didnt see the funcionality). How can i solve this problem? @c4rl0sbr4v0 @ajitbohra

Thanks!

@cbravobernal
Copy link
Contributor

cbravobernal commented Nov 5, 2023 •
edited
Loading

Thanks for the PR!

It was a permissions issue. You still need some more PRs done in the project to be able to assign labels to PRs. Meanwhile, feel free to ping me and I will update it asap.

Let's wait for someone to review it and keep the conversation in the PR.

Good job! 🎉

@valerogarte
Copy link
Contributor

Now we just have to wait for @ajitbohra @ryanwelcher @juanmaguitar @fabiankaegy @ndiego to accept it.

Thanks!

@cbravobernal cbravobernal mentioned this issue Nov 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@valerogarte valerogarte

Labels
[Block] List Affects the List Block Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#55702 - Control dimensions (margin and padding) of the list-item block valerogarte/gutenberg
4 participants
@dkjensen @jordesign @cbravobernal @valerogarte