-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Font Library: No message appears when pressing the Update button #54601
Comments
@jasmussen Can you share your ideas on the messaging UI? |
Yes, I touched on that in this PR review. I'm suggesting there do either of the following. Either when you press Update, the dialog is immediately closed, and the multi entity saving interface is opened, this one: Or, when the Update button is pressed, you are taken to your library tab in the dialog. After all, you just enqueued it to be in your library. I think we should avoid snackbars in this iteration, the basic flow should be in place before we add notices to explain. |
Raising this issue to bug and adding the Accessibility label, as the lack of visible and audible feedback isn't ideal. |
To ideally solve this problem, I think the first step would be to manage the notification as a state instead of context. The notification is only active on that screen and is supposed to be unmounted when the screen changes. Currently, The notification is managed as a context, and notification status is preserved even when switching screens, so there is redundant processing to reset the notification status (example). I will also address this issue as part of #58428. |
What problem does this address?
In the font library, for example, when you change the variation you use, you can click the Update button. When you click that button, the state is indeed saved, but no message is displayed.
What is your proposed solution?
In my opinion, there is a solution to either of the following:
Personally, I prefer the latter approach. As I understand it, the behavior of the Update button has the same role as the Save button in the Global Styles. Also, the font variation setting is part of the global style.
I think whether or not to save changes made in global styles should be centralized in one button.
Screencast
7265fc7a03ca0dd6b4c87ee70be7c856.mp4
The text was updated successfully, but these errors were encountered: