Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font Library: Uninstall modal text is redundant #54528

Closed
t-hamano opened this issue Sep 17, 2023 · 0 comments · Fixed by #57368
Closed

Font Library: Uninstall modal text is redundant #54528

t-hamano opened this issue Sep 17, 2023 · 0 comments · Fixed by #57368
Labels
[Feature] Typography Font and typography-related issues and PRs Needs Design Feedback Needs general design feedback. [Type] Copy Issues or PRs that need copy editing assistance

Comments

@t-hamano
Copy link
Contributor

What problem does this address?

The confirmation dialog that appears when uninstalling a font feels a little redundant compared to other modals in the Site Editor.

uninstall-font-modal

Also, the button text can be quite long depending on the locale. The following shows what the text would look like if it were localized to Japanese.

uninstall-font-modal-translated

What is your proposed solution?

I think it would be better to change to a simpler and more consistent UI as shown below.

uninstall-font-modal-expected

This is consistent with the UI of other modals in the Site Editor. For example, below is the confirmation dialog when deleting a custom template.

template-delete-modal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Typography Font and typography-related issues and PRs Needs Design Feedback Needs general design feedback. [Type] Copy Issues or PRs that need copy editing assistance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants