Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command Palette: Block commands that do not work on the selected block are displayed #53921

Closed
t-hamano opened this issue Aug 24, 2023 · 2 comments · Fixed by #53988
Closed
Assignees
Labels
[Package] Block editor /packages/block-editor [Type] Bug An existing feature does not function as intended

Comments

@t-hamano
Copy link
Contributor

Description

Related to #52509

By #52509, commands related to blocks were added. However, you will see commands that are not expected to be used with the selected block.

Step-by-step reproduction instructions

N/A

Screenshots, screen recording, code snippet

382ee8aae45d89414776d677731ec185.mp4

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@t-hamano t-hamano added [Type] Bug An existing feature does not function as intended [Package] Block editor /packages/block-editor labels Aug 24, 2023
@ntsekouras
Copy link
Contributor

Thanks for the issue. I'll open a PR about the grouping commands soon.

@t-hamano
Copy link
Contributor Author

t-hamano commented Aug 28, 2023

Thank you for bringing this issue to your attention. From my new research, it seems that all block commands need to be given some sort of condition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Block editor /packages/block-editor [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants