Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style Variations: Display current modifications in the "Browse styles" panel #53476

Closed
jameskoster opened this issue Aug 9, 2023 · 8 comments
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Needs Design Needs design efforts. [Type] Enhancement A suggestion for improvement.

Comments

@jameskoster
Copy link
Contributor

The "Browse styles" panel shows which style variation is active.

It can sometimes be useful to understand in more detail which blocks, elements, etc. that variation modifies. In this issue let's explore designs to surface those details with appropriate prominence.

@jameskoster jameskoster added Needs Design Needs design efforts. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Aug 9, 2023
@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Aug 30, 2023
@annezazu annezazu moved this to Needs Design in WordPress 6.4 Editor Tasks Aug 30, 2023
@annezazu
Copy link
Contributor

Related to this, we need to show what custom CSS is attached to each variation: #47433

@ellenbauer
Copy link

@jameskoster Before adding design ideas, I just want to be extra sure that with 'shows which style variation is active' the slightly darker border around the active style variation is meant, or? Could we maybe also discuss making this active state a little more visible?

We are creating a theme right now with a lot of style variations and I feel the active state should pop out a little more visible, see screenshot:

Screenshot 2023-09-06 at 2 44 22 PM

Also, when we are adding more information anyway, we could maybe add the name of the active style variation to this list?

@jameskoster
Copy link
Contributor Author

@ellenbauer I don't think anything is totally off the table :) Looking forward to seeing ideas!

@annezazu
Copy link
Contributor

annezazu commented Feb 8, 2024

After a review by core editor triage leads and core editor tech leads, this has been removed from the board for 6.5 consideration.

@mtias
Copy link
Member

mtias commented Sep 29, 2024

What's the status of this one?

@jameskoster
Copy link
Contributor Author

I know I opened this issue, but it's been a while and could use some clarity since the UI/UX has changed a little.

Are we talking about displaying information regarding modifications the user has made to the active style variation? Or is it about showing which modifications each style variation applies on top of the default one?

The wording in the issue would suggest the latter, but the former seems more useful to me :)

@mtias
Copy link
Member

mtias commented Sep 30, 2024

Yeah, it seems perhaps we should close this one and continue on the broad work of style variation management :)

@jameskoster
Copy link
Contributor Author

Yes I think so, saving/resetting is mostly covered in #45371.

@jameskoster jameskoster closed this as not planned Won't fix, can't repro, duplicate, stale Sep 30, 2024
@github-project-automation github-project-automation bot moved this from Next to Done in Design priorities Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Needs Design Needs design efforts. [Type] Enhancement A suggestion for improvement.
Projects
Status: Done
Status: Punted to 6.5
Development

No branches or pull requests

5 participants