Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Editor: Pressing the back button repeats the movement between All Template Parts page and Patterns page #52690

Closed
t-hamano opened this issue Jul 17, 2023 · 3 comments
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended

Comments

@t-hamano
Copy link
Contributor

Description

I have only found one condition of occurrence, but I have found a case where I cannot return to the admin page by pressing the back button when I have moved pages in a specific order.

Step-by-step reproduction instructions

Below is one procedure I found.

  1. Access Appearance > Editor
  2. Click the canvas area
  3. Select the Header template part
  4. Click "Edit" button
  5. Click on the logo button in the top left corner
  6. It should open the template parts view mode
  7. Click the back button
  8. It should take you to All Template Parts page
  9. Click the back button
  10. It should take you to Patterns page
  11. Click the back button
  12. It should take you back to the All Template Parts page, not the admin page.
  13. Steps 9 through 12 should repeat endlessly.

Screenshots, screen recording, code snippet

9f724948f91e2df87991f1b6052a59f1.mp4

Environment info

  • WordPress version: 6.3-beta4-56247
  • Gutenberg version: 16.2.1 (trunk)
  • Browser: Chrome, Firefox

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@t-hamano t-hamano added [Type] Bug An existing feature does not function as intended [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Jul 17, 2023
@ndiego ndiego moved this to ❓ Triage in WordPress 6.3.x Editor Tasks Jul 27, 2023
@annezazu
Copy link
Contributor

This seems to be related to: #52910 Can you retest with that PR?

@ndiego ndiego moved this from ❓ Triage to 📥 Todo in WordPress 6.3.x Editor Tasks Jul 27, 2023
@aaronrobertshaw
Copy link
Contributor

I can't replicate the issue following the steps here on trunk. I believe this was fixed by #52910.

Are you happy to close this @t-hamano?

@noisysocks
Copy link
Member

Yeah fixed by #52910.

@github-project-automation github-project-automation bot moved this from 📥 Todo to ✅ Done in WordPress 6.3.x Editor Tasks Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended
Projects
No open projects
Development

No branches or pull requests

4 participants