Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LinkControl: Remove home URL from suggestion #52572

Closed
richtabor opened this issue Jul 12, 2023 · 2 comments · Fixed by #54553
Closed

LinkControl: Remove home URL from suggestion #52572

richtabor opened this issue Jul 12, 2023 · 2 comments · Fixed by #54553
Assignees
@getdave
Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Status] In Progress Tracking issues with work in progress [Type] Task Issues or PRs that have been broken down into an individual action to take

Comments

@richtabor
Copy link
Member

As a follow-up to #52523, I propose removing the site's home URL from the suggestion?.url.

For example, on my site richtabor.com, the About page would render /about, instead of https://richtabor.com/about. This would help reduce the information density and improve scan-ability.

In the screenshot below, localhost:888 would be omitted.

CleanShot 2023-07-12 at 11 32 33
@richtabor richtabor added the [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) label Jul 12, 2023
@richtabor richtabor mentioned this issue Jul 12, 2023
Closed
13 tasks
@jordesign jordesign added the [Type] Task Issues or PRs that have been broken down into an individual action to take label Jul 18, 2023
@richtabor richtabor added this to Polish Aug 14, 2023
@richtabor richtabor moved this to Needs development in Polish Aug 14, 2023
@annezazu annezazu moved this to Needs Dev / Todo in WordPress 6.4 Editor Tasks Aug 30, 2023
@getdave
Copy link
Contributor

getdave commented Sep 15, 2023

In theory this is a case of:

  • getting the baseURL for the site.
  • search and replace on the value

However we should probably try and keep the Link Control ignorant of such things so it could be a little trickier.

@richtabor
Copy link
Member Author

richtabor commented Sep 15, 2023 •
edited
Loading

Could we add a parameter within filterURLForDisplay to omit the baseURL?

@getdave getdave mentioned this issue Sep 18, 2023
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Sep 18, 2023
@getdave getdave moved this from Needs development to Needs review in Polish Sep 18, 2023
@getdave getdave moved this from Needs Dev / Todo to Needs Review in WordPress 6.4 Editor Tasks Sep 18, 2023
@github-project-automation github-project-automation bot moved this from Needs Review to Done in WordPress 6.4 Editor Tasks Sep 21, 2023
@github-project-automation github-project-automation bot moved this from Needs review to Done in Polish Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@getdave getdave

Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Status] In Progress Tracking issues with work in progress [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
Polish
Status: Done
WordPress 6.4 Editor Tasks
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove base url from link control search results WordPress/gutenberg
3 participants
@getdave @richtabor @jordesign