Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Welcome guides: improve initial focus to avoid skipping content #52284

Closed
afercia opened this issue Jul 4, 2023 · 0 comments · Fixed by #52300
Closed

Welcome guides: improve initial focus to avoid skipping content #52284

afercia opened this issue Jul 4, 2023 · 0 comments · Fixed by #52300
Assignees
Labels
[Feature] NUX Anything that impacts the new user experience [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Design Feedback Needs general design feedback. [Package] Edit Post /packages/edit-post [Package] Edit Site /packages/edit-site [Package] Edit Widgets /packages/edit-widgets [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release

Comments

@afercia
Copy link
Contributor

afercia commented Jul 4, 2023

Description

After #52014, the welcome guides modal dialogs that have only one 'page' (as in: no wizard steps) do not render the X close button any longer.

Please se this comment: #52014 (comment)

This change has an impact on accessibility:

  • Initial focus now goes to the last element within the modal dialog
  • As such, screen reader users may not have any clue that there's some content before the 'get started' button.
  • Providing an user experience that potentially forces users to miss content is lett than ideal.
  • Previously, initial focus was set to the 'Close' button: this way, screen reaaer users didn't miss any content, as the content was provided in a natural order. As such, I'm going to mark this issue as a regression.
  • In this cases, initial focus should be set on the modal dialog itself.

Aside

Design considerations / UI consistency: there are now seven welcome guides in use in the editor:

  • edit-post
    • welcomeGuide
    • welcomeGuideTemplate
  • edit-site
    • welcomeGuide
    • welcomeGuideStyles
    • welcomeGuidePage
    • welcomeGuideTemplate
  • edit-widgets
    • welcomeGuide

They look and behave differently. I'll leave this to the design team consideration. IMHO, I'd tend to think that consistency in visuals and user experience is key and should prevail on any other consideration. Screenshot to illustrate the seven welcome guides:

Screenshot 2023-07-04 at 14 54 49

Step-by-step reproduction instructions

  • To make sure the welcome guides are rendered, use a clean database or delete the wp_persisted_preferences user meta in your database.
  • Go to the various places in the editor where welcome guides are used:
  • edit-post
    • welcomeGuide
    • welcomeGuideTemplate
  • edit-site
    • welcomeGuide
    • welcomeGuideStyles
    • welcomeGuidePage
    • welcomeGuideTemplate
  • edit-widgets
    • welcomeGuide
  • Observe some of the welcome guides modal dialogs do show a X close button, some don't.
  • Observe the initial focus is set on different elements depending on the presence of the X close button.
  • Observe when there's no X close button, the initial focus is set on the last element: the 'Get started' or 'Continue' button.
  • Optionally: use a screen reader and observe that when initial focus is set to the last element, the previous content is not announced (of course) so that users may not have a clue there's some content before the current focus point.

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@afercia afercia added [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Design Feedback Needs general design feedback. [Feature] NUX Anything that impacts the new user experience [Type] Regression Related to a regression in the latest release [Package] Edit Post /packages/edit-post [a11y] Keyboard & Focus [Package] Edit Widgets /packages/edit-widgets [Package] Edit Site /packages/edit-site labels Jul 4, 2023
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jul 5, 2023
@priethor priethor removed [a11y] Keyboard & Focus [Status] In Progress Tracking issues with work in progress labels Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] NUX Anything that impacts the new user experience [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Design Feedback Needs general design feedback. [Package] Edit Post /packages/edit-post [Package] Edit Site /packages/edit-site [Package] Edit Widgets /packages/edit-widgets [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants