-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Footnotes: Excerpts displays the link text as a * after the text content #52035
Comments
@ellatrix and cc'ing @WordPress/gutenberg-design |
Good issue. I'd suggest that the excerpt commonly exists to be shown in archive views, where the actual footnote is unlikely to show up. In that light, I'd suggest trying to hide it from the excerpt. |
I wonder if we should just remove the asterisk altogether 🤔 That would also remove the CSS hack where we have to hide it to make place for the counter as a pseudo element. OR we have to remove the CSS counter and replace in PHP. |
Removing the asterisk altogether would make the excerpt have no indication of footnotes, correct? I'd agree with that, it seems fine to have an entirely footnote-less excerpt. |
I chatted a bit with Ella about this. At first glance, I kind of like the "safety" of CSS-only decorations, in that footnotes gracefully disappear if we are in a context in which we might not expect them, like excerpts. On the other hand, we can't simply ignore syndication, emails and general consumption via the REST API. I think that part of the solution is to think of footnotes as a first-class concept of posts in the same way that We have room to play with the exact markup that we choose for the anchors, where/how we style them (with stylesheets, with inline styles, with server-side injection, etc.), but we can't shy away from thinking of footnotes as a first-class concept — think of Finally, let's not forget that there is a lot of nuance even within those modalities: we can be fairly confident that nor the anchors nor the notes should be visible in an excerpt, but when it comes to emails like newsletters I can imagine that different site admins have different expectations (are the footnotes essential to the content, or should users visit the website to read everything?). And what about general consumers using the REST API? Presumably they should be given the full content, but — unlike in the front end — we don't know how they'll handle CSS (especially fancy CSS like |
What problem does this address?
When the post content has one or more footnotes, the excerpt block picks up the link text, the visually hidden star, as part of the content.
This might be correct, but I found the result difficult to read.
Example from Twenty Twenty Three:
What is your proposed solution?
I am not sure if it is worth trying to remove the star from the excerpt. Normally in excerpts, link texts are not removed, but I am not sure if the star indicates clearly enough that it represents a footnote.
The text was updated successfully, but these errors were encountered: