Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dimension controls: Order by horizontal & vertical #51680

Open
hanneslsm opened this issue Jun 20, 2023 · 3 comments
Open

Dimension controls: Order by horizontal & vertical #51680

hanneslsm opened this issue Jun 20, 2023 · 3 comments
Labels
[Type] Enhancement A suggestion for improvement.

Comments

@hanneslsm
Copy link

What problem does this address?

The new dimension controls are awesome!
However, there is a UX inconsistency in the order of the controls when switching from the default to "Custom".
The default is: Top / Bottom and Left / Right (= Horizontal & vertical)
The custom order is: Top, Right, Bottom, Left. (= Mixed)

GB 16.0 Default Horizontal & vertical
image

|

What is your proposed solution?

The custom order should reflect what's already displayed on the default, meaning:

  • Top
  • Bottom
  • Left
  • Right

Maybe we can even add a tiny bit of padding between "bottom" and "left" subtly distinguish between Horizontal & Vertical
Here is a quick mockup:

GB 16.0 Custom (Mixed) Proposal (Keeping Horizontal & Vertical order)
image image
@hanneslsm
Copy link
Author

The new order should of course also be adapted in the Menu then
image

@ndiego ndiego added the [Type] Enhancement A suggestion for improvement. label Jun 20, 2023
@richtabor
Copy link
Member

It's tricky, as top right bottom left is the order in which the CSS shorthand property is written (source).

@hanneslsm
Copy link
Author

hanneslsm commented Jun 20, 2023

It's tricky, as top right bottom left is the order in which the CSS shorthand property is written (source).

Yeah, I know, but that's not an argument I can bring up with clients. They surely will get confused why the order has changed. The user journey (getting primed with an order already) and target group (not technical users) are different for Gutenberg than for CSS, so I'd argue that we finally break away from the technical constrains and build a more intuitive interface.

Also, one could argue that those ("advanced" padding and margin) features are mainly for (web-)designers. In that case, let's see what Figma does with borders (they even have a different name for it: "strokes"):
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

3 participants