Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flaky Test] should disappear when closed via click event or Escape key #50807

Closed
github-actions bot opened this issue May 20, 2023 · 0 comments · Fixed by #51365
Closed

[Flaky Test] should disappear when closed via click event or Escape key #50807

github-actions bot opened this issue May 20, 2023 · 0 comments · Fixed by #51365
Labels
[Type] Flaky Test Auto-generated flaky test report issue

Comments

@github-actions
Copy link

github-actions bot commented May 20, 2023

Flaky test detected. This is an auto-generated issue by GitHub Actions. Please do NOT edit this manually.

Test title

should disappear when closed via click event or Escape key

Test path

/test/e2e/specs/site-editor/style-book.spec.js

Errors

[2023-05-20T02:49:47.003Z] Test passed after 1 failed attempt on trunk.
[2023-05-21T10:32:08.220Z] Test passed after 1 failed attempt on update/gen-block-lib-list.
[2023-05-21T11:00:06.061Z] Test passed after 1 failed attempt on add/tag-selection-dropdown.
[2023-05-22T06:59:08.355Z] Test passed after 1 failed attempt on try/reduce-specificity-of-flex-and-grid-margin-override.
[2023-05-22T11:16:14.082Z] Test passed after 1 failed attempt on add/url-assertion.
[2023-05-22T19:24:57.299Z] Test passed after 1 failed attempt on fix/wp-env-rootless-docker.
[2023-05-22T21:33:52.333Z] Test passed after 1 failed attempt on try/search-button-only.
[2023-05-23T12:25:06.567Z] Test passed after 1 failed attempt on try/nav-block-slugs-existing-api.
[2023-05-24T06:23:22.632Z] Test passed after 1 failed attempt on add/tag-selection-dropdown.
[2023-05-24T10:56:46.562Z] Test passed after 1 failed attempt on add/back-to-top.
[2023-05-24T11:37:03.773Z] Test passed after 1 failed attempt on refactor/upload-perf-test-themes.
[2023-05-24T12:53:18.525Z] Test passed after 1 failed attempt on refactor/upload-perf-test-themes.
[2023-05-24T13:09:41.054Z] Test passed after 1 failed attempt on interactivity.
[2023-05-25T05:38:32.914Z] Test passed after 1 failed attempt on fix/undo-redo.
[2023-05-26T07:52:59.980Z] Test passed after 1 failed attempt on update/cover-background-label.
[2023-05-26T11:07:34.154Z] Test passed after 1 failed attempt on update/cover-background-label.
[2023-05-26T13:25:26.022Z] Test passed after 1 failed attempt on trunk.
[2023-05-26T20:12:31.033Z] Test passed after 1 failed attempt on enhance/wp-env-run-local.
[2023-05-27T08:32:12.231Z] Test passed after 1 failed attempt on trunk.
[2023-05-28T15:54:36.290Z] Test passed after 1 failed attempt on fix/firefox-screen-reader-aria-describedby.
[2023-05-29T09:22:37.162Z] Test passed after 1 failed attempt on trunk.
[2023-05-29T13:36:28.318Z] Test passed after 1 failed attempt on trunk.
[2023-05-29T13:48:10.323Z] Test passed after 1 failed attempt on update/eager-map-private-selectors.
[2023-05-29T16:02:37.775Z] Test passed after 1 failed attempt on rnmobile/fix/dictation-regression-ios.
[2023-05-29T16:46:39.665Z] Test passed after 1 failed attempt on trunk.
[2023-05-30T00:59:43.509Z] Test passed after 1 failed attempt on trunk.
[2023-05-30T04:42:43.564Z] Test passed after 1 failed attempt on rnmobile/fix-gallery-v1-caption.
[2023-05-30T08:34:37.471Z] Test passed after 1 failed attempt on add/query-pagination-additional-formats.
[2023-05-30T10:30:46.960Z] Test passed after 1 failed attempt on update/block-toolbar-unlock-label.
[2023-05-30T13:26:05.713Z] Test passed after 1 failed attempt on rnmobile/update/upgrade-android-13.
[2023-05-30T13:49:17.500Z] Test passed after 1 failed attempt on trunk.
[2023-05-30T14:34:26.481Z] Test passed after 1 failed attempt on rnmobile/add-columns-test.
[2023-05-30T16:13:11.924Z] Test passed after 1 failed attempt on trunk.
[2023-05-31T00:03:57.849Z] Test passed after 1 failed attempt on trunk.
[2023-05-31T04:54:33.841Z] Test passed after 1 failed attempt on add/add-new-page.
[2023-05-31T12:26:15.874Z] Test passed after 1 failed attempt on trunk.
[2023-05-31T12:57:28.960Z] Test passed after 1 failed attempt on rnmobile/update/upgrade-android-13.
[2023-05-31T14:18:04.894Z] Test passed after 1 failed attempt on rnmobile/update/upgrade-android-13.
[2023-06-01T06:18:59.067Z] Test passed after 1 failed attempt on rnmobile/release_1.96.1.
[2023-06-01T06:59:04.933Z] Test passed after 1 failed attempt on trunk.
[2023-06-01T08:14:32.326Z] Test passed after 1 failed attempt on trunk.
[2023-06-01T11:32:02.160Z] Test passed after 1 failed attempt on trunk.
[2023-06-01T11:51:51.750Z] Test passed after 1 failed attempt on try/additional-block-contents-component.
[2023-06-01T16:27:05.495Z] Test passed after 1 failed attempt on update/data-selector-binding.
[2023-06-01T21:00:42.769Z] Test passed after 1 failed attempt on add/distraction-free-to-site-editor.
[2023-06-02T00:40:47.455Z] Test passed after 1 failed attempt on trunk.
[2023-06-02T08:19:35.798Z] Test passed after 1 failed attempt on trunk.
[2023-06-02T13:13:23.329Z] Test passed after 1 failed attempt on update/data-selector-binding.
[2023-06-02T13:57:47.468Z] Test passed after 1 failed attempt on browse-mode-navigation-options.
[2023-06-02T17:39:06.500Z] Test passed after 1 failed attempt on fix/51010-block-tooltip-when-dragging-media-into-the-canvas.
[2023-06-05T06:57:02.453Z] Test passed after 1 failed attempt on add/block-removal-warning.
[2023-06-06T06:56:24.525Z] Test passed after 1 failed attempt on update/save-hub-behaviour.
[2023-06-06T08:46:04.433Z] Test passed after 1 failed attempt on trunk.
[2023-06-06T14:51:11.879Z] Test passed after 1 failed attempt on add/ability-to-set-block-editing-mode-by-clientid.
[2023-06-07T02:37:18.329Z] Test passed after 1 failed attempt on update/rename-page-content-lock.
[2023-06-07T08:39:27.651Z] Test passed after 1 failed attempt on try/auto-inserting-blocks.
[2023-06-07T08:45:09.231Z] Test passed after 1 failed attempt on try/font-library.
[2023-06-08T00:55:53.541Z] Test passed after 1 failed attempt on trunk.
[2023-06-08T02:40:42.505Z] Test passed after 1 failed attempt on rnmobile/release_1.97.0.
[2023-06-08T06:13:43.075Z] Test passed after 1 failed attempt on update/dry-up-content-blocks-list.
[2023-06-08T09:45:25.404Z] Test passed after 1 failed attempt on trunk.
[2023-06-08T12:31:47.407Z] Test passed after 1 failed attempt on fix/post-title-iframe-focus.
[2023-06-08T14:35:33.315Z] Test passed after 1 failed attempt on add/categories-list-type.
[2023-06-08T15:52:18.323Z] Test passed after 1 failed attempt on trunk.
[2023-06-08T20:41:02.255Z] Test passed after 1 failed attempt on tweak/linkcontrol-suggestions.
[2023-06-08T20:56:54.269Z] Test passed after 1 failed attempt on try/link-control-show-suggestions-on-dirty.
[2023-06-08T22:26:21.906Z] Test passed after 1 failed attempt on rnmobile/docs/fix-broken-links.
Error: Timed out 5000ms waiting for expect(received).toBeVisible()
Call log:
  - expect.toBeVisible with timeout 5000ms
  - waiting for locator('role=region[name="Style Book"i]')
  - waiting for locator('role=region[name="Style Book"i]')

    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/site-editor/style-book.spec.js:27:5
@github-actions github-actions bot added the [Type] Flaky Test Auto-generated flaky test report issue label May 20, 2023
github-actions bot referenced this issue May 26, 2023
* Use checkbox control

* Align controls

* Fix toggle replaced with checkbox
github-actions bot referenced this issue May 27, 2023
* Details Block: Enable by default on Gutenberg plugin without opt-in

* Add fixture

* Stabilize the block
github-actions bot referenced this issue May 29, 2023
* Fix lightbox ui appearing with interactivity experiment disabled

* Update e2e tests to enable the experiment
github-actions bot referenced this issue May 30, 2023
* Try adding dynamic page templates to pages section

* remove recent heading in pages

* Static homepage case

* Back button should go back to Pages

* Fix order of home and blog pages

* Try fetching all the pages

* Stick templates to bottom

* Stick item positioning

* Revert custom back button behaviour

* Move manage link to dynamic pages group

* Remove home/posts page suffixes

* Address feedback

* Add back truncation

* Copy array for reorder

* Consolidate sticky styles

---------

Co-authored-by: Saxon Fletcher <[email protected]>
Co-authored-by: James Koster <[email protected]>
github-actions bot referenced this issue May 30, 2023
* Post Template Block: Set block context via filter

In the Post Template block's render callback, use the `render_block_context` filter to set `postId` and `postType` context, rather than passing that context directly to the `WP_Block` constructor.

This approach arguably follows our established patterns with regard to handling block context better. Notably, with the previous approach, we were only setting block context for the Post Template block itself. In this PR, we extend it to apply to all child blocks, including ones that are dynamically inserted, e.g. via the `render_block` filter. This is relevant for Auto-inserting blocks (see #50103).

This follows the precedent of the Comment Template block, see #50279.

Furthermore, add some test coverage to guard against duplicated block-supports class names, which was an issue in a previous iteration of this PR.
github-actions bot referenced this issue Jun 1, 2023
…1146)

* #49815 added `settings.layout.wideSize` as the default value for the maximum viewport size in relation to calculating fluid fontsize values.
Unfortunately this maxViewPortWidth value was not being passed to `getTypographyFontSizeValue()`
This commit correct this omission and adds extra unit tests to both the JS and PHP versions.

* To avoid backwards compat problems I'm trying to keep the function signature the same, hence the gymnastics here.
Because we support fluid: true and fluid: {...values}, we have to ensure the param object is correctly set so that we can know if fluid typography is enabled or not.
The alternative could be a third argument to the `getTypographyFontSizeValue()` function, e.g., `isFluidEnabled`

* My blod is typo

* Why chain? Break the chains!
github-actions bot referenced this issue Jun 1, 2023
* Update native HorizontalRule primitive component
* Remove react-native-hr package references
github-actions bot referenced this issue Jun 1, 2023
…illProps` (#51013)

* Update README.md

Add info and example about `fillProps` prop on `Slot`

* Update packages/components/src/slot-fill/README.md

Co-authored-by: Nick Diego <[email protected]>

* Update packages/components/src/slot-fill/README.md

Co-authored-by: Nick Diego <[email protected]>

---------

Co-authored-by: Nick Diego <[email protected]>
github-actions bot referenced this issue Jun 2, 2023
…dants (#51079)

* Add inert attribute to disabled blocks that have only disabled descendants

* Fix typo

---------

Co-authored-by: ramon <[email protected]>
github-actions bot referenced this issue Jun 8, 2023
…owns (#51154)

* DropdownMenu: read variant from context

* Toolbar: do not set `variant` prop on popover (rely on context system instead)

* Use named export for better storybook doc generation

* Provide context value in more toolbar components

* Hook Dropdown into context system, update DropdownMenu and CircularOptionPicker

* Remove toolbar variant popover prop where the context system can be used instead

* Add comment where the context system currently doesn't work

* Use placement prop instead of legacy "position" prop

* Add some temporary TODO comments

* Set toolbar variant for Dropdown in the context system

* Remove explicit variant prop from block alignment matrix control

* Toolbar: Only set context in the top-level component

* Remove `toolbar` variant from instances using `Dropdown`

* Simplify Dropdown implementation

* Tidy up types

* Remove toolbar variant storybook example for Popover

* CHANGELOG

* Complete renaming internal type

* Remove duplicate hardcoded classnames(already added by context connexct)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Flaky Test Auto-generated flaky test report issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

0 participants