-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigation on Browse Mode: Add edit button #50581
Comments
In the defunct navigation editor project we had a similar problem: how to edit a tree of blocks as in a way which is indicative that the tree is a navigation menu, without having a block that will contain the tree to style. In the later stages of the project we landed on an UI which centered a rectangle on a gray canvas: Should we try the same approach - which was attained by a lot of iteration on "horizontal" displays - to create the UX of editing a tree in a wider space where we also have inspectors for the containing blocks, but no inspector for the parent block? It seems fit for a data view of the navigation data. Also in that screen:
These bits from that investment should inform the work in #39286 which implements the bulk of this issue. It's also worth noting that we have not solved the problem that since #34899 the navigation block inserts "navigation link" blocks via "direct insert" but the default state of the navigation link block is custom link. We would want that the default to be the page variation. This limitation will also show up in the isolated editor too. Another thing to note from past lessons is that using blocks just for presetation (a fake navigation block to enable the menu building UX) leads to issues as we need to manage an "in-memory" entiti - see #34839 s |
Fixed in #39286 |
Building on #50578 and #50579, we need to enable users to add pages to their navigation.
When users have a navigation selected (or if they have only one), add an edit button next the the "Navigation" title in the Navigation panel. This edit button will open the canvas preview to display the selected navigation in focus mode:
The text was updated successfully, but these errors were encountered: