Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation on Browse Mode: Add edit button #50581

Closed
scruffian opened this issue May 12, 2023 · 2 comments
Closed

Navigation on Browse Mode: Add edit button #50581

scruffian opened this issue May 12, 2023 · 2 comments
Labels
[Block] Navigation Affects the Navigation Block

Comments

@scruffian
Copy link
Contributor

Building on #50578 and #50579, we need to enable users to add pages to their navigation.

When users have a navigation selected (or if they have only one), add an edit button next the the "Navigation" title in the Navigation panel. This edit button will open the canvas preview to display the selected navigation in focus mode:

Screenshot 2023-05-12 at 12 40 32
@draganescu
Copy link
Contributor

In the defunct navigation editor project we had a similar problem: how to edit a tree of blocks as in a way which is indicative that the tree is a navigation menu, without having a block that will contain the tree to style.

In the later stages of the project we landed on an UI which centered a rectangle on a gray canvas:

image

Should we try the same approach - which was attained by a lot of iteration on "horizontal" displays - to create the UX of editing a tree in a wider space where we also have inspectors for the containing blocks, but no inspector for the parent block? It seems fit for a data view of the navigation data.

Also in that screen:

  • we used a wrapper navigation block only to allow the same rules of interaction but the block thre had its edit component filtered and most (all?) of the inspector options were removed.
  • the block did allow renaming the navigation

image

These bits from that investment should inform the work in #39286 which implements the bulk of this issue.

It's also worth noting that we have not solved the problem that since #34899 the navigation block inserts "navigation link" blocks via "direct insert" but the default state of the navigation link block is custom link. We would want that the default to be the page variation. This limitation will also show up in the isolated editor too.

Another thing to note from past lessons is that using blocks just for presetation (a fake navigation block to enable the menu building UX) leads to issues as we need to manage an "in-memory" entiti - see #34839

s

@scruffian
Copy link
Contributor Author

Fixed in #39286

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block
Projects
None yet
Development

No branches or pull requests

2 participants