Navigation block: prompt to add link/select post only when selecting individual menu item

[annezazu]

What problem does this address?

This came up as part of the FSE Outreach Program's Front Page Fun call for testing:

one example is when you’re editing the navigation block and want to add a new item. Suppose you don’t choose content for your item (for any reason). If you click outside the sidebar to exit, do something else, and then click again in any part of the navigation block afterwards — not in the navigation item you were working with — you are presented with a popup to select the content for the previously created navigation item (GIF). The previous context is remembered for me, but I was not expecting that. I wasn’t even thinking about that item anymore. It took some time for me to understand what the UI was trying to nudge me to select the content. I think this should either be removed or made more obvious. That popup should only appear if I click specifically on the item I was editing before, not in other areas of the navigation block itself.

Here's a video:

adding.link.mov

What is your proposed solution?

Only prompt someone to add a link or select a block when the individual item is selected rather than when the entire navigation block is selected. Consider adding in more context as well rather than just opening the inserter experience.

[annezazu]

@getdave this might be worth considering as part of larger link control work.

[draganescu]

I cannot reproduce this on trunk anymore:

navigation-popover-correct.mp4

[getdave]

This should also never be a problem again due to fix in #50774 and accompanying e2e test (regression) coverage I added.