Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing focus style for the 'Choose a pattern' modal dialog listbox options #49333

Closed
afercia opened this issue Mar 24, 2023 · 0 comments · Fixed by #49334
Closed

Missing focus style for the 'Choose a pattern' modal dialog listbox options #49333

afercia opened this issue Mar 24, 2023 · 0 comments · Fixed by #49334
Assignees
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Edit Site /packages/edit-site [Type] Bug An existing feature does not function as intended

Comments

@afercia
Copy link
Contributor

afercia commented Mar 24, 2023

Description

Keyboard users need a visible focus style to see where focus is and consequently be able to use an user interface. This is a basic requirement for accessibility and usability.

When creating a new template in the site editor, the preview options in the 'Choose a pattern' modal dialog do have a hover style:

Screenshot 2023-03-24 at 10 44 09

but they don't have a focus style:

keyboard

Turns out in the related stylesheet there's a :focus rule but it's applied to an element that is not focusable....

Step-by-step reproduction instructions

  • Go to the site editor.
  • Create a new custom template.
  • Wait.
  • The 'Choose a pattern' modal dialog opens.
  • Hover your mouse on the available patterns previews and observe there's a hover style.
  • Use the Tab key to navigate through the focusable elements within the modal and observe the patterns previews don't have a focus style.

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@afercia afercia added [Type] Bug An existing feature does not function as intended [a11y] Keyboard & Focus [Package] Edit Site /packages/edit-site labels Mar 24, 2023
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Mar 24, 2023
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label May 11, 2023
@priethor priethor added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). and removed [a11y] Keyboard & Focus labels Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Edit Site /packages/edit-site [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants