Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use WP_HTML_Tag_Processor for duotone classes #49169

Closed
ajlende opened this issue Mar 17, 2023 · 0 comments · Fixed by #49212
Closed

Use WP_HTML_Tag_Processor for duotone classes #49169

ajlende opened this issue Mar 17, 2023 · 0 comments · Fixed by #49212
Assignees
@ajlende
Labels
[Feature] Media Anything that impacts the experience of managing media [Type] Enhancement A suggestion for improvement.

Comments

@ajlende
Copy link
Contributor

ajlende commented Mar 17, 2023 •
edited
Loading

Using the tag processor will be more reliable than the current regular expressions used to update classes in duotone.

See #49103 (comment)
@ajlende ajlende mentioned this issue Mar 17, 2023
Open
14 tasks
@Thelmachido Thelmachido added [Feature] Media Anything that impacts the experience of managing media [Type] Enhancement A suggestion for improvement. labels Mar 20, 2023
@ajlende ajlende self-assigned this Mar 20, 2023
@ajlende ajlende mentioned this issue Mar 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ajlende ajlende

Labels
[Feature] Media Anything that impacts the experience of managing media [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace regex with tag processor for duotone class render WordPress/gutenberg
2 participants
@ajlende @Thelmachido