Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

position setting is not included in the JSON Schema for theme.json #49010

Closed
pbiron opened this issue Mar 11, 2023 · 2 comments
Closed

position setting is not included in the JSON Schema for theme.json #49010

pbiron opened this issue Mar 11, 2023 · 2 comments
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Enhancement A suggestion for improvement.

Comments

@pbiron
Copy link

pbiron commented Mar 11, 2023

Description

In a comment on Sticky position block support, @mrleemon pointed out that the new position setting is not yet included in the JSON Schema for theme.json.

Please add it to the JSON schema prior to the release of WP 6.2.

Step-by-step reproduction instructions

View the JSON schema and notice that the position setting is not included ;-)

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes
@kathrynwp kathrynwp added Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Enhancement A suggestion for improvement. labels Mar 13, 2023
@andrewserong
Copy link
Contributor

Hi @pbiron, thanks for opening this one. I merged a PR a few days ago that adds it to the schema over in: #48948

@andrewserong andrewserong mentioned this issue Mar 13, 2023
Merged
@pbiron
Copy link
Author

pbiron commented Mar 13, 2023

Thanx Andrew! I'll close this now because the merged PR has covered. it.

(I'll make one comment over on the PR, regarding merging into core).

@pbiron pbiron closed this as completed Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pbiron @kathrynwp @andrewserong