Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Logo: Add preview when image used as Site Icon #48608

Open
westonruter opened this issue Mar 1, 2023 · 2 comments
Open

Site Logo: Add preview when image used as Site Icon #48608

westonruter opened this issue Mar 1, 2023 · 2 comments
Labels
[Block] Site Logo Affects the Site Logo Block Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.

Comments

@westonruter
Copy link
Member

What problem does this address?

The Site Logo block allows for the selected image to also be set as the Site Logo. Nevertheless, the description for that toggle does not indicate that the Site Icon is square, and it does not indicate that the selected image will be cropped to become square. Contrast this with the Site Icon control in the Customizer where there is a preview showing how an image will be cropped as a square and where it will show up in a mock browser UI.

What is your proposed solution?

  • When the "Use as site icon" toggle is checked, that the same Site Icon preview from the Customizer be rendered below the toggle.
  • The copy should also be updated to note that the icon is a square and what its dimensions are.
  • Show a warning when the Site Logo will end up being cropped to be less than 512 pixels square.
  • (Out of scope) Optionally provide a UI to do a custom crop of the Site Logo or to select an entirely different image to be used as the Site Icon. Maybe this gets into a larger architectural question about managing global settings in the Site Editor.
Current Site Logo Block Current Site Icon in Customizer
Selected an image for Site Logo with the block settings opened Site icon control in Customizer
@wparasae
Copy link

Related issue: WordPress/Learn#512 (comment)

@richtabor
Copy link
Member

) Optionally provide a UI to do a custom crop of the Site Logo or to select an entirely different image to be used as the Site Icon.

Perhaps so — currently the Site Icon is not cropped, if it's added within by the Site Logo block.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Site Logo Affects the Site Logo Block Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants