Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to blocks makes inline images block level #4859

Closed
maddisondesigns opened this issue Feb 5, 2018 · 7 comments · Fixed by #19064
Closed

Convert to blocks makes inline images block level #4859

maddisondesigns opened this issue Feb 5, 2018 · 7 comments · Fixed by #19064
Assignees
Labels
[Feature] Block Transforms Block transforms from one block to another [Feature] Paste [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Milestone

Comments

@maddisondesigns
Copy link

maddisondesigns commented Feb 5, 2018

Issue Overview

After opening a page in Gutenberg that was created using the Classic Editor, I then selected the Convert to Blocks option. Some of my content then disappeared.

This is the page upon first opening it up in Gutenberg

gutenberg-converttoblocks1

After selecting Convert to Blocks, the second image disappeared and was instead replaced with a copy of the first image.

gutenberg-converttoblocks2

This issue is blocked on #2043.

Steps to Reproduce (for bugs)

  1. Create new Page using the Classic Editor
  2. Insert dummy content and two or more images, inline in the text
  3. Publish page
  4. Open the Page using Gutenberg
  5. Select Convert to Block from the icon next to the block

Expected Behavior

I expect all my content to be converted to the appropriate blocks (except for inline images)

Current Behavior

Every image in the page is replaced with the first image

Firefox Quantum 58.0.1 (64-bit)
Gutenberg 2.1.0
WordPress 4.9.2

@jasmussen
Copy link
Contributor

The small omega symbol seems an issue with inline images, tracked in #2043.

The second issue, subsequent images being replaced with the first, was fixed in #4749, and will be in 2.1.

Should we either rename this ticket to be about converting Classic blocks with inline images not working, or close this and add a comment to #2043?

@maddisondesigns
Copy link
Author

@jasmussen I presume you mean Gutenberg 2.2? I'm already using v2.1.0.

If you want to rename it so it's more about not converting inline images in Classic blocks, that's fine.

@jasmussen
Copy link
Contributor

Ack, sorry, yes 2.2. I'll rename the ticket, thanks.

@jasmussen jasmussen changed the title Convert to Blocks loses content Convert to blocks makes inline images block level Feb 5, 2018
@jeffpaul jeffpaul added the [Type] Bug An existing feature does not function as intended label Mar 8, 2018
@danielbachhuber danielbachhuber added this to the Merge Proposal: Editor milestone Jun 4, 2018
@danielbachhuber danielbachhuber added the [Feature] Block Transforms Block transforms from one block to another label Jun 4, 2018
@ZebulanStanphill
Copy link
Member

Now that #6959 is merged, it is possible to fix this issue (which still exists).

@mtias mtias added [Feature] Paste Needs Testing Needs further testing to be confirmed. labels Jul 17, 2018
@brandonpayton
Copy link
Member

I can also confirm this remains an issue.

@brandonpayton brandonpayton removed the Needs Testing Needs further testing to be confirmed. label Sep 26, 2018
@mtias mtias modified the milestones: Merge: Editor, WordPress 5.0 Oct 12, 2018
@ellatrix
Copy link
Member

Could the issue be retested with the latest version? There were some changes in behaviour.

@ellatrix ellatrix added the Needs Testing Needs further testing to be confirmed. label Nov 27, 2018
@youknowriad
Copy link
Contributor

I confirm this is still happening.

@youknowriad youknowriad removed the Needs Testing Needs further testing to be confirmed. label Apr 3, 2019
@ellatrix ellatrix self-assigned this Apr 23, 2019
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Block Transforms Block transforms from one block to another [Feature] Paste [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants