Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all exhaustive-deps warnings from codebase #47917

Open
getdave opened this issue Feb 9, 2023 · 0 comments
Open

Remove all exhaustive-deps warnings from codebase #47917

getdave opened this issue Feb 9, 2023 · 0 comments
Labels
[Tool] ESLint plugin /packages/eslint-plugin [Type] Code Quality Issues or PRs that relate to code quality

Comments

@getdave
Copy link
Contributor

getdave commented Feb 9, 2023

With the merge of #24914 the exhaustive deps eslint rule is now active in "warning" mode.

We need to work towards removing those warnings in order that we can switch the setting to "error" in future.

The strategy for doing this is outline by @ciampo below:


For the strategy towards "zero warnings", I suggest the approach that we took for the components package:

  • focus on one package at a time
  • remove all warnings, either by satisfying eslint demants, or by ignoring them when a rewrite would be complicated (while also adding a code comment explaining the reason for the disable)
  • once all warnings are gone, change the rule for that specific package from warn to error to avoid re-introducing more errors
  • pick a new package, repeat

Originally posted by @ciampo in #24914 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Tool] ESLint plugin /packages/eslint-plugin [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

No branches or pull requests

1 participant