Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WP 6.2] Hybrid themes: wide and full width settings are lost from the toolbar #47857

Closed
mayuge3 opened this issue Feb 8, 2023 · 3 comments · Fixed by #47961
Closed

[WP 6.2] Hybrid themes: wide and full width settings are lost from the toolbar #47857

mayuge3 opened this issue Feb 8, 2023 · 3 comments · Fixed by #47961
Assignees
Labels
[Feature] Layout Layout block support, its UI controls, and style output. [Priority] High Used to indicate top priority items that need quick attention [Type] Regression Related to a regression in the latest release

Comments

@mayuge3
Copy link

mayuge3 commented Feb 8, 2023

Description

When I use hybrid theme in WordPress 6.2 beta1 nightly, wide and full width settings are lost from the toolbar.

Also, the wide/full-width cover block becomes the content width.

Step-by-step reproduction instructions

Tested with WordPress 6.2 beta1 nightly without Gutenberg plugin.

  1. Use a classic theme without theme.json. I use TT1 (Twenty Twenty-one).
  2. Add blocks to the post and set its width to wide or full.
  3. Add TT3's theme.json to TT1 theme folder. TT1 is now a hybrid theme.
  4. Open the post editor again, wide and full width settings are lost from the toolbar.

Screenshots, screen recording, code snippet

- TT1 without theme.json TT1 with theme.json
Cover cover01 cover02
Image image01 image02

Environment info

WP6.2-beta1-55293 (latest nightly via Beta Tester plugin), instawp install
TT1 and theme.json of TT3 included in nightly.
Tested without Gutenberg plugin

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@Mamaduka Mamaduka added the Needs Testing Needs further testing to be confirmed. label Feb 8, 2023
@carolinan
Copy link
Contributor

I can reproduce this.
6.2-beta1-55293 via beta tester plugin, with or without Gutenberg trunk active.
Mac Os, PHP 8.1.9, Chrome

@ndiego ndiego moved this to ❓ Triage in WordPress 6.2 Editor Tasks Feb 8, 2023
@ndiego ndiego moved this from ❓ Triage to 📥 Todo in WordPress 6.2 Editor Tasks Feb 9, 2023
@Mamaduka
Copy link
Member

I can also reproduce the issue. Alignments are available in WP 6.1.x but not when using the latest Gutenberg or 6.2-beta1.

I added the following theme.json file to TT1 for testing.

{
	"$schema": "https://schemas.wp.org/trunk/theme.json",
	"version": 2,
	"settings": {
		"layout": {
			"contentSize": "800px",
			"wideSize": "1000px"
		}
	}
}

@Mamaduka Mamaduka added [Type] Regression Related to a regression in the latest release [Feature] Layout Layout block support, its UI controls, and style output. [Priority] High Used to indicate top priority items that need quick attention and removed Needs Testing Needs further testing to be confirmed. labels Feb 10, 2023
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Feb 10, 2023
@github-project-automation github-project-automation bot moved this from 📥 Todo to ✅ Done in WordPress 6.2 Editor Tasks Feb 13, 2023
@mayuge3
Copy link
Author

mayuge3 commented Feb 15, 2023

Alighments now work in 6.2-beta2-55343. Thank you!

@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Layout Layout block support, its UI controls, and style output. [Priority] High Used to indicate top priority items that need quick attention [Type] Regression Related to a regression in the latest release
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

5 participants