Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media Placeholder - 'Insert from URL' popover incorrectly positioned #47817

Closed
talldan opened this issue Feb 7, 2023 · 4 comments
Closed

Media Placeholder - 'Insert from URL' popover incorrectly positioned #47817

talldan opened this issue Feb 7, 2023 · 4 comments
Labels
[Block] Image Affects the Image Block [Block] Video Affects the Video Block [Feature] Media Anything that impacts the experience of managing media [Type] Bug An existing feature does not function as intended

Comments

@talldan
Copy link
Contributor

talldan commented Feb 7, 2023

Description

The media placeholder 'Insert from URL' popover is incorrectly positioned.

Step-by-step reproduction instructions

  1. Add a video or image block
  2. Select the 'Insert from URL' button

Expected - the popover is centered below the button
Actual - the popover is positioned to the top left

It seems even worse if you open List View and then select the button.

Screenshots, screen recording, code snippet

With List View closed:
Screen Shot 2023-02-07 at 5 10 47 pm

With List View open:
Screen Shot 2023-02-07 at 5 11 01 pm

Environment info

Latest Gutenberg trunk

Brave / Mac OS

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@talldan talldan added [Type] Bug An existing feature does not function as intended [Feature] Media Anything that impacts the experience of managing media [Block] Image Affects the Image Block [Block] Video Affects the Video Block labels Feb 7, 2023
@talldan talldan moved this to ❓ Triage in WordPress 6.2 Editor Tasks Feb 7, 2023
@ndiego ndiego moved this from ❓ Triage to 📥 Todo in WordPress 6.2 Editor Tasks Feb 9, 2023
@apeatling
Copy link
Contributor

I can't reproduce this in Safari or Chrome on Mac, it's positioned correctly. I do see the problem when opening the list view:

2023-02-09 12 42 21

@ntsekouras
Copy link
Contributor

This issue happens in the iframed post editor and since we'll disable it for 6.2 here, I'll remove this issue from the respective board.

@apeatling
Copy link
Contributor

Makes sense, thanks for the extra context on the iframed post editor part.

@mtias
Copy link
Member

mtias commented Jul 5, 2023

I think this is ok now even in the iframe version.

@mtias mtias closed this as completed Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Image Affects the Image Block [Block] Video Affects the Video Block [Feature] Media Anything that impacts the experience of managing media [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

4 participants