Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow enabling and disabling Layout at block level in theme.json #47807

Closed
tellthemachines opened this issue Feb 7, 2023 · 4 comments · Fixed by #53378
Closed

Allow enabling and disabling Layout at block level in theme.json #47807

tellthemachines opened this issue Feb 7, 2023 · 4 comments · Fixed by #53378
Assignees
Labels
[Feature] Layout Layout block support, its UI controls, and style output. [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@tellthemachines
Copy link
Contributor

What problem does this address?

Currently it's not possible to enable or disable the Layout block support for specific blocks in theme.json.

What is your proposed solution?

Implement support for enabling and disabling layout from theme.json settings, e.g.:

"blocks": {
			"core/group": {
				"__experimentalLayout": false
			}
		}
@tellthemachines tellthemachines added [Type] Enhancement A suggestion for improvement. [Feature] Layout Layout block support, its UI controls, and style output. labels Feb 7, 2023
@andrewserong
Copy link
Contributor

andrewserong commented Feb 7, 2023

Thanks for writing this one up! It might be good to combine this with stabilising the layout support at the same time, so that the theme.json file doesn't need to use the __experimental prefix.

Also, another thought: would setting layout to false disable only the UI, or also the style output for the layout? Taken a step further, if core/group was set to layout: false, would that mean that Row and Stack variations would no longer appear in the inserter, and no layout classnames would be added to the rendered block?

@tellthemachines
Copy link
Contributor Author

Taken a step further, if core/group was set to layout: false, would that mean that Row and Stack variations would no longer appear in the inserter, and no layout classnames would be added to the rendered block?

Without actually testing this, I think that the variations would still appear. Should they? I'm not sure. Also not sure regarding the classnames, I think we'll have to experiment and see what works best! Feedback from extenders would also be welcome.

@andrewserong
Copy link
Contributor

I think we'll have to experiment and see what works best! Feedback from extenders would also be welcome.

Sounds good! It'll be fascinating see what the right level of switching things off is for folks 👍

@github-actions
Copy link

github-actions bot commented Aug 7, 2023

Hi,
This issue has gone 180 days without any activity. This means it is time for a check-in to make sure it is still relevant. If you are still experiencing this issue with the latest versions, you can help the project by responding to confirm the problem and by providing any updated reproduction steps.
Thanks for helping out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Layout Layout block support, its UI controls, and style output. [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants