Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BlockPatternSetup enhancements #46381

Open
jcheringer opened this issue Dec 7, 2022 · 4 comments
Open

BlockPatternSetup enhancements #46381

jcheringer opened this issue Dec 7, 2022 · 4 comments
Labels
[Feature] Extensibility The ability to extend blocks or the editing experience [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Type] Feedback Issues that relate purely to feedback on a feature that isn't necessarily actionable

Comments

@jcheringer
Copy link

What problem does this address?

Jetpack Forms (Form block) has received several improvements recently.
One of them was the possibility of exploring Patterns right from the Form block placeholder.

For that implementation, we followed the suggestion of using the BlockPatternSetup as it was used in the Query Loop block.
It served our purposes well, and now we'd like to propose a few improvement points we noticed and/or received as feedback:

  • The default modal viewMode is set to Carousel, and it's not possible to change it externally. In certain scenarios, the Grid view is more suitable, so it'd be great if we could choose the default viewMode.

  • The modal doesn't show the title and/or the Pattern's description. For some use cases, showing a title and/or a description of the Pattern would make it more apparent to the user the purpose of the Pattern.
    There's already a discussion about this topic(Pattern Inserter: consideration to always show each pattern title #45595), but it applies to another visualization of the Patterns. We want to use this opportunity to leave our 'vote' in favor of showing, or at least have the possibility to show the title and/or Pattern's description.

  • We got some feedback that, when previewing the Patterns in the Carousel viewMode, sometimes the next/previous slide is shown briefly during the transition and the view is a bit shaky. The same issue can be noticed using the Query Loop block.

Please let me know if I can clarify or if you need more details for any of the points above.

@annezazu annezazu added [Feature] Extensibility The ability to extend blocks or the editing experience [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Type] Feedback Issues that relate purely to feedback on a feature that isn't necessarily actionable labels Dec 7, 2022
@annezazu
Copy link
Contributor

annezazu commented Dec 7, 2022

@ntsekouras curious if you have time to review this and share some thoughts based on your work in general with patterns and the query loop block.

@ntsekouras
Copy link
Contributor

Thanks for the issue @jcheringer!

The initial view mode suggestion has already landed.

The modal doesn't show the title and/or the Pattern's description.

I created a PR for the inserter list and I guess the discussions will dictate the way forward for this one.

We got some feedback that, when previewing the Patterns in the Carousel viewMode, sometimes the next/previous slide is shown briefly during the transition and the view is a bit shaky. The same issue can be noticed using the Query Loop block.

Maybe a small video for this would help..

@jcheringer
Copy link
Author

Hey @ntsekouras, thanks for starting to handle those!

Here is a recording from the Query Loop block

Screen.Recording.on.2022-12-09.at.09_49_37.webm

And here is one from the Form Block

Form.Pattern.Modal.mov

@richtabor
Copy link
Member

The default modal viewMode is set to Carousel, and it's not possible to change it externally. In certain scenarios, the Grid view is more suitable, so it'd be great if we could choose the default viewMode.

Agreed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Extensibility The ability to extend blocks or the editing experience [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Type] Feedback Issues that relate purely to feedback on a feature that isn't necessarily actionable
Projects
None yet
Development

No branches or pull requests

4 participants