Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover Image H2 does not appear in Table of Contents #4606

Closed
AdamSoucie opened this issue Jan 19, 2018 · 1 comment
Closed

Cover Image H2 does not appear in Table of Contents #4606

AdamSoucie opened this issue Jan 19, 2018 · 1 comment

Comments

@AdamSoucie
Copy link

Issue Overview

After converting an H2 from a standard heading to a cover image, the H2 was removed from the Table of Contents.

Steps to Reproduce (for bugs)

  1. Create a heading block
  2. Observe the table of contents entry for the heading
  3. Convert the heading block to a Cover Image block
  4. Observe the change in the ToC

Observed in Chrome on an MBP running High Sierra

Expected Behavior

If the cover image text is an H2, it should remain in the Table of Contents as an H2

Current Behavior

Right now, the H2 is not appearing in the ToC

Possible Solution

If #3444 gets fully implemented, this becomes somewhat of a moot point. That being said, having the ability to make any header a cover image would be greatly appreciated.

Related Issues and/or PRs

#3444

@jasmussen
Copy link
Contributor

Per discussions in #4616, we decided that #3444 is indeed the way to go. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants