You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The outermost wrapper for InputControl uses Flex, which has a height: 100% by default. This can cause unintended results when used inside a Grid.
What is your proposed solution?
We would normally use a VStack instead of Flex in a use case like this, which doesn't have the 100% height, but we also need to support the HStack-like use case to support labelPosition prop. So instead I think we could pass in appropriate direction/expanded props to the Flex depending on the labelPosition to achieve the correct styles. This is probably just an oversight in how the Flex was used in InputControl.
The text was updated successfully, but these errors were encountered:
What problem does this address?
The outermost wrapper for InputControl uses
Flex
, which has aheight: 100%
by default. This can cause unintended results when used inside a Grid.What is your proposed solution?
We would normally use a VStack instead of Flex in a use case like this, which doesn't have the 100% height, but we also need to support the HStack-like use case to support
labelPosition
prop. So instead I think we could pass in appropriatedirection
/expanded
props to the Flex depending on thelabelPosition
to achieve the correct styles. This is probably just an oversight in how the Flex was used in InputControl.The text was updated successfully, but these errors were encountered: