Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InputControl: Fix Flex usage in wrapper #45877

Closed
mirka opened this issue Nov 18, 2022 · 0 comments · Fixed by #46213
Closed

InputControl: Fix Flex usage in wrapper #45877

mirka opened this issue Nov 18, 2022 · 0 comments · Fixed by #46213
Assignees
Labels
[Package] Components /packages/components [Type] Bug An existing feature does not function as intended

Comments

@mirka
Copy link
Member

mirka commented Nov 18, 2022

What problem does this address?

The outermost wrapper for InputControl uses Flex, which has a height: 100% by default. This can cause unintended results when used inside a Grid.

What is your proposed solution?

We would normally use a VStack instead of Flex in a use case like this, which doesn't have the 100% height, but we also need to support the HStack-like use case to support labelPosition prop. So instead I think we could pass in appropriate direction/expanded props to the Flex depending on the labelPosition to achieve the correct styles. This is probably just an oversight in how the Flex was used in InputControl.

@mirka mirka added [Type] Bug An existing feature does not function as intended [Package] Components /packages/components labels Nov 18, 2022
@mirka mirka self-assigned this Nov 30, 2022
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Nov 30, 2022
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants