Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate string: 'Distraction free' and 'Distraction Free' #45523

Closed
atachibana opened this issue Nov 3, 2022 · 1 comment · Fixed by #45538
Closed

Duplicate string: 'Distraction free' and 'Distraction Free' #45523

atachibana opened this issue Nov 3, 2022 · 1 comment · Fixed by #45538
Assignees
Labels
Internationalization (i18n) Issues or PRs related to internationalization efforts [Type] Enhancement A suggestion for improvement.

Comments

@atachibana
Copy link
Contributor

Description

In the Polyglots of Gutenberg, we see two string 'Distraction free' and 'Distraction Free'. These are come from:

packages/edit-post/src/components/header/writing-menu/index.js
label={ __( 'Distraction free' ) }

packages/edit-post/src/components/preferences-modal/index.js
label={ __( 'Distraction Free' ) }

'Distraction free' (lower 'free') is used in most places (ex. 'Distraction free mode turned on.'), so I think it should be consistent with that text. 'Distraction Free' (capitalized 'Free') is used in the following two places (One is snapshot).

packages/edit-post/src/components/preferences-modal/index.js
label={ __( 'Distraction Free' ) }

packages/edit-post/src/components/preferences-modal/test/__snapshots__/index.js.snap
Distraction Free

Step-by-step reproduction instructions

n/a

Screenshots, screen recording, code snippet

See above.

Environment info

  • Gutenberg 14.4.0

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@Mamaduka Mamaduka added [Type] Enhancement A suggestion for improvement. Internationalization (i18n) Issues or PRs related to internationalization efforts labels Nov 3, 2022
@annezazu
Copy link
Contributor

annezazu commented Nov 3, 2022

@draganescu as a heads up!

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Nov 4, 2022
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internationalization (i18n) Issues or PRs related to internationalization efforts [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants