Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Components theming: use new accent color in every component #45249

Closed
Tracked by #44116
ciampo opened this issue Oct 24, 2022 · 0 comments · Fixed by #45289
Closed
Tracked by #44116

Components theming: use new accent color in every component #45249

ciampo opened this issue Oct 24, 2022 · 0 comments · Fixed by #45289
Assignees
@chad1008
Labels
[Package] Components /packages/components

Comments

@ciampo
Copy link
Contributor

ciampo commented Oct 24, 2022 •
edited by chad1008
Loading

Part of #44116

What

Swap hardcoded accent/theme color styles in favour of the newly introduced CSS variables, both for Sass and Emotion-based components.

There will be three variables to refactor towards:

  • $components-color-accent
  • $components-color-accent-darker-10
  • $components-color-accent-darker-20

Why

Part of the #44116 effort to add theming to the Components library.

How

Mainly a search and replace process, work is being performed in #45289.
@ciampo ciampo mentioned this issue Oct 24, 2022
Open
23 tasks
@ciampo ciampo added the [Package] Components /packages/components label Oct 24, 2022
@ciampo ciampo changed the title Refactor all usages of and start getting a feeling for how the APIs behave Components theming: use new accent color in every component Oct 24, 2022
@chad1008 chad1008 mentioned this issue Oct 25, 2022
Merged
22 tasks
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Oct 25, 2022
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chad1008 chad1008

Labels
[Package] Components /packages/components
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Components: use new theming accent color in all components WordPress/gutenberg
3 participants
@ciampo @chad1008 @priethor