Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigation: Improve readability by refactoring the logic around fallbacks #45039

Closed
scruffian opened this issue Oct 17, 2022 · 1 comment
Closed

Navigation: Improve readability by refactoring the logic around fallbacks #45039

scruffian opened this issue Oct 17, 2022 · 1 comment
Labels
[Block] Navigation Affects the Navigation Block [Type] Code Quality Issues or PRs that relate to code quality

Comments

@scruffian
Copy link
Contributor

The navigation block does different things depending on the state of the user's site - do they have any wp_navigations? Do they have a classic menu? etc. It's very hard to understand this behaviour by reading the code. We should refactor it so that these direction switches are visible in code. For instance legacy placeholder, default behavior with uncontrolled blocks etc.
@scruffian scruffian added [Type] Code Quality Issues or PRs that relate to code quality [Block] Navigation Affects the Navigation Block labels Oct 17, 2022
@scruffian scruffian mentioned this issue Oct 17, 2022
Open
7 tasks
@getdave
Copy link
Contributor

getdave commented Jul 3, 2023

This has been completed in the work around fallbacks in the 6.3 cycle. See #50032

@getdave getdave closed this as completed Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Block] Navigation Affects the Navigation Block [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@scruffian @getdave