Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot add blocks to a nested group or row block when editing templates #44989

Closed
jonathanbossenger opened this issue Oct 14, 2022 · 11 comments · Fixed by #45050
Closed

Cannot add blocks to a nested group or row block when editing templates #44989

jonathanbossenger opened this issue Oct 14, 2022 · 11 comments · Fixed by #45050
Assignees
Labels
[Block] Group Affects the Group Block (and row, stack and grid variants) [Priority] High Used to indicate top priority items that need quick attention [Type] Bug An existing feature does not function as intended

Comments

@jonathanbossenger
Copy link
Contributor

Description

When editing a theme template, if you add a Group block or a Row block inside a Group block (ie a nested Group or Row) it's not possible to add blocks to the nested Group or Row.

Step-by-step reproduction instructions

  1. Edit a block theme template (tested in both tt2 and a newly created block theme)
  2. Add a Group block
  3. Add a nested Group block inside the parent Group block
  4. The UI to add additional blocks inside the nested Group block does not appear.
  5. If you switch the nested Group to a nested Row, you also cannot add blocks

Screenshots, screen recording, code snippet

Nested group

nested-group

Nested row

nested-row

Environment info

  • WordPress 6.0.2 and Gutenberg trunk
  • Tested in Brave browser
  • Tested on both an M1 Macbook Pro, and Ubuntu 22.04

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@bph bph added [Block] Group Affects the Group Block (and row, stack and grid variants) [Type] Bug An existing feature does not function as intended labels Oct 14, 2022
@bph
Copy link
Contributor

bph commented Oct 14, 2022

I can reproduce this.
See the video

Group-in-group-inserter-doesn.t.appear.mp4

I tested a bit further.
Using the Inserter from the left sidebar, drops blocks outside the group block even if it's selected.

My workaround

  • add outside the first group block a heading block and a paragraph block.
  • made them a group.
  • added a new empty paragraph block in the first group block and
  • dragged the second group block inside the first group block in the space of the empty block.

I can see a sibling inserter.
Here another video

workaround-group-block.mp4

It seems the sibling inserter doesn't appear when the group is empty

@bph
Copy link
Contributor

bph commented Oct 14, 2022

This seems to be happening on both, post editor and in the site editor.

@carolinan
Copy link
Contributor

carolinan commented Oct 17, 2022

I can reproduce this on WP 6.1-RC1-54520, with and without Gutenberg active.
FSE theme: I can reproduce it in the block editor, so not only when editing templates.
Classic theme: I can not reproduce it in the block editor, I can see the inserter button in the nested group.

@ockham ockham added the [Priority] High Used to indicate top priority items that need quick attention label Oct 17, 2022
@ndiego
Copy link
Member

ndiego commented Oct 17, 2022

I can reproduce can well.

@ndiego ndiego moved this from Triage to Todo in WordPress 6.1 Editor Tasks Oct 17, 2022
@tellthemachines
Copy link
Contributor

This is a regression caused by the styles added in #44660; I'm looking at a fix now.

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Oct 17, 2022
@tellthemachines tellthemachines moved this from Todo to In Progress in WordPress 6.1 Editor Tasks Oct 17, 2022
Repository owner moved this from In Progress to Done in WordPress 6.1 Editor Tasks Oct 18, 2022
@uniquesolution
Copy link

uniquesolution commented Oct 22, 2022

Its not got resolved yet, I tested it in instawp , using Wordpress 6.0.3 and Gutenberg plugin version 14.3.1 and not able to add anything inside child group block.
here is the login credential to test
https://ndly-finch-zadi.instawp.xyz/wp-admin/
Username : bapajacofi4242
Password : ztxNw18WrGbSM6c7LJsg

I also tested with wordpress beta 6.1, guternberg ver. 14.3.1 have same issue in that too.

@carolinan
Copy link
Contributor

Hi @uniquesolution. You are right, the fix is not in Gutenberg 14.3.1. It will be in the plugin in a future update.

@bph
Copy link
Contributor

bph commented Oct 22, 2022

From the PR, it seems the fix made it into 6.1 RC2 @uniquesolution could test it again, please?

@uniquesolution
Copy link

@bph checked in wordpress 6.1 RC2 with gutenberg ver 14.3.1 installed. Still, the same issue persists.

@ndiego
Copy link
Member

ndiego commented Oct 22, 2022

I just tested this. The issue is resolved in 6.1 RC2. However, when Gutenberg v14.3.1 is active, it appears that the issue is not resolved since the fix is not in Gutenberg yet, and Gutenberg styles generally override Core. @uniquesolution try using just 6.1 RC2 without Gutenberg active, and everything should work as expected. Let me know if not. Thanks!

@bph
Copy link
Contributor

bph commented Oct 22, 2022

The fix is slated for 14.4 version of the Gutenberg plugin release next week. The 14.4 RC is already available under releases.

@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Group Affects the Group Block (and row, stack and grid variants) [Priority] High Used to indicate top priority items that need quick attention [Type] Bug An existing feature does not function as intended
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

8 participants