Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global Styles: revisit order of blocks to improve information architecture #44840

Open
annezazu opened this issue Oct 10, 2022 · 11 comments
Open
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.

Comments

@annezazu
Copy link
Contributor

Similar to how the blocks in the inserter have been re-examined to weight and group them appropriately, I believe the same needs to be done with the Styles > Blocks interface:

Screen Shot 2022-10-10 at 6 31 22 PM

For example, it feels really odd that archives, audio, calendar, and categories list are in the visible section on desktop. What can we do to perhaps add categories to match what you see in the Inserter (have consistency) and weight what folks are more likely to adjust here? cc @WordPress/gutenberg-design for thoughts.

@annezazu annezazu added [Type] Enhancement A suggestion for improvement. Needs Design Feedback Needs general design feedback. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Oct 10, 2022
@jasmussen
Copy link
Contributor

Good issue. Search helps a great deal, prior to that I would've wanted alphabetization at the very least, as that seems like it would be the case in lists like these. I understand weighting is important. In that light, should Paragraph be so high? Isn't it better to change GS > Typography instead of just the paragraph block?

However could/should we combine categories with alphabetization? I.e. we could have "Common", "Layout", "Templates"? Alternately, we could duplicate the same categories the inserter has, for some recognition, perhaps with the added "Templates" category?

@annezazu
Copy link
Contributor Author

For some reason, my brain goes to wanting categories, similar to what we see in the Inserter. That may be an old way of thinking though but, for now, it feels like it might help with consistency in experience.

@jameskoster
Copy link
Contributor

Alphabetisation seems like a good middle-ground for now, with filtering by category being a further enhancement.

@apeatling
Copy link
Contributor

apeatling commented Jan 6, 2023

I've tested and approved the PR above for this, @jasmussen / @annezazu / @jameskoster just a final check to make sure you're still good with this list changing to alphabetical before it's merged? I think it's an improvement, just a very noticeable one so good to get another thumbs up.

@annezazu annezazu moved this to 🎨 Needs design in Gutenberg Phase 2: Customization Jan 13, 2023
@annezazu annezazu moved this from 🎨 Needs design to 🏗 In progress in Gutenberg Phase 2: Customization Jan 13, 2023
@annezazu
Copy link
Contributor Author

@apeatling let's roll with it. Thank you for following up here!

@mtias
Copy link
Member

mtias commented Jan 17, 2023

I don't think we should do alphabetical. We used to have this initially and changed it because it's unusable as a sorting scheme when you have various libraries coexisting and you see obscure blocks at the top. The intention was to match how the inserter itself lists things.

@dsas
Copy link
Contributor

dsas commented Jan 17, 2023

The alphabetisation PR currently open (#45678) lists all core blocks alphabetically, and then all non-core blocks alphabetically. I think it's an improvement over what currently exists but it isn't the ideal end state. If someone is about to open a PR for the ideal end state then lets just drop #45678, otherwise I think it should be merged (or have been merged months ago :)) to improve things until the ideal end state is ready.

@annezazu
Copy link
Contributor Author

I also think the Inserter listing needs to be improved when you're in the Site Editor so perhaps these two need to be addressed in tandem: #42480

@richtabor
Copy link
Member

The intention was to match how the inserter itself lists things.

Just a note that this Styles > Blocks list isn't the ideal experience for finding and styling blocks — that's where the Style Book comes into play. Where you can click on a block in the Style Book and have its panel open up for editing in the Global Styles sidebar.

That saying, I'm fine with pulling the same sorting that we use in the inserter — though I'd say this is low priority.

@mtias
Copy link
Member

mtias commented Jan 26, 2023

We should also allow selecting any block when GS is open and do a deep selection of the block types panel, not just in Style Book.

@priethor priethor moved this from ❓ Triage to 🏗️ In Progress in WordPress 6.2 Editor Tasks Jan 26, 2023
@ndiego ndiego moved this from 🏗️ In Progress to 🦵 Punted to 6.3 in WordPress 6.2 Editor Tasks Feb 23, 2023
@priethor priethor moved this from 🏗 In progress to 💻 Needs development in Gutenberg Phase 2: Customization Apr 19, 2023
@ndiego ndiego moved this to ❓ Triage in WordPress 6.3.x Editor Tasks May 23, 2023
@ndiego
Copy link
Member

ndiego commented Jun 12, 2023

Hey team, just checking in as this issue is on the 6.3 Project Board, and I do not see any recent activity. Are we still aiming for 6.3 with this? Otherwise, I will remove it from the board. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.
Projects
Status: 💻 Needs development
Development

No branches or pull requests

8 participants