-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LayoutPanel: Switch to using the ToolsPanel #44560
Comments
Great ticket, thank you. One addition, when we move this to become a tools panel, we should hide by default the option to allow wrapping: As a separate sidenote on the components (cc @ciampo), the justification icons should all be gray-900 (almost black). This is my bad, I included them in gray in a mockup, apologies. This is only for icons, to note, non active text items in a segmented control should still be dark gray. |
We should certainly do this. It allows us to continue expanding layout controls without expanding layout complexity. Related to #62895 (comment) |
This issue is to propose / track progress on switching the
LayoutPanel
used by the layout block support over to using theToolsPanel
instead ofPanelBody
.As new controls are added to the
LayoutPanel
, the area of the layout panel within the inspector controls increases, and there will likely be many blocks for which new controls should be hidden by default. As with the Typography (#33744) and Dimensions (#32392) panels previously, switching over to theToolsPanel
will allow blocks to define which layout controls to display by default.For reference, here are screenshots of the Typography panel next to the Layout panel:
(only font size is displayed by default)
It's been mentioned a few times on other Github issues (e.g. recently by @jasmussen here: #35849 (comment)), so I thought this issue could be a useful place for looking at that task in isolation.
There are related earlier discussions about overhauling the panel and what gets included in it (e.g. #34698), however for the purposes of this issue, the task is to keep all the controls as-is for the moment, but refactor to the
ToolsPanel
so that in separate tasks, the decision of what goes where can be made.The text was updated successfully, but these errors were encountered: