-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Represent default font size in slider #44229
Comments
Oh interesting, I read the brief as when no font size is set, suggest which point on the slider it would match. 🤔 |
If no font size is set (it is inherited from css), then we can't determine which value it would match? 🤔 I saw this as more about connecting the setting in global styles to the control we find when editing locally. Apologies if that's separate. |
The font size can be set in Global Styles, in which case we would know whether it matched a given notch in the slider. |
We should. But it hasn't been implemented here. I think that's the issue? As an example, here's my font size setting from the Typography section of global styles: But when I go to edit the Paragraph block in global styles, or just select a paragraph while editing a post, here's what I see: The label tells me the default size is set, but the corresponding segment (M) isn't highlighted. |
Right, that's the baseline, and works okay, I think the question is whether we need more than that. |
Selecting M explicitly for a paragraph is not the same as M being the inherited default when nothing is locally set but M is the most immediate value passed in the tree. |
I believe #49278 captures this in a more holistic way. All controls need a solution to this problem. |
Now that we have more concrete mechanisms for knowing what is the default font size coming for text from the global styles tree, can we represent it on the segmented control if it matches one of the preset sizes?
I'd imagine we would use a lighter gray for these cases.
The text was updated successfully, but these errors were encountered: