Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Components: Clean up utils/config-values.js file #43997

Open
mirka opened this issue Sep 8, 2022 · 3 comments
Open

Components: Clean up utils/config-values.js file #43997

mirka opened this issue Sep 8, 2022 · 3 comments
Labels
[Package] Components /packages/components [Type] Code Quality Issues or PRs that relate to code quality

Comments

@mirka
Copy link
Member

mirka commented Sep 8, 2022

What problem does this address?

Similar to #40392, the config-values.js file contains a lot of values that are likely irrelevant to the current direction of the components package. This sometimes causes confusion to component implementors, in that they reach for values from this file when they maybe shouldn't.

What is your proposed solution?

See if any of the values can be salvaged as useful constants, and for any other values we can demote them.
@mirka mirka added the [Package] Components /packages/components label Sep 8, 2022
@github-actions
Copy link

This issue has gone 30 days without any activity.

@github-actions
Copy link

Hi,
This issue has gone 30 days without any activity. This means it is time for a check-in to make sure it is still relevant. If you are still experiencing this issue with the latest versions, you can help the project by responding to confirm the problem and by providing any updated reproduction steps.
Thanks for helping out.

@github-actions github-actions bot added the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Oct 12, 2022
@ciampo
Copy link
Contributor

ciampo commented Oct 12, 2022 •
edited
Loading

I believe this issue is still relevant (especially given the recent theming effort), going to remove the "stale" label

@ciampo ciampo removed the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Oct 12, 2022
@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Aug 30, 2023
@mirka mirka added [Type] Code Quality Issues or PRs that relate to code quality and removed [Type] Enhancement A suggestion for improvement. labels Apr 18, 2024
@mirka mirka mentioned this issue Apr 18, 2024
Merged
@mirka mirka mentioned this issue Sep 19, 2024
Merged
@mirka mirka mentioned this issue Dec 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Package] Components /packages/components [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mirka @ciampo @jordesign