Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List view: Certain screen readers still switch modes when options button receives focus #43729

Closed
alexstine opened this issue Aug 31, 2022 · 5 comments · Fixed by #44291
Closed
Assignees
Labels
[Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended

Comments

@alexstine
Copy link
Contributor

Description

Whenever I open the list view, my screen reader remains in edit mode. This means all keyboard input gets sent to the application, Gutenberg. This is good because it allows me to navigate up and down the left side of the grid, or block names. The problem becomes when I enter the right column where the options buttons are, landing on a button forces screen readers from edit mode to browse mode. When a screen reader is in browse mode, you are experiencing the document with the virtual cursor. This means that up, down, left, and right arrows no longer navigate the grid.

How to fix

I think adding aria-hidden="true" to the button may work but it will need testing. Essentially, the right side of the grid needs to have similar markup to the left side of the grid.

Steps to reproduce

  1. On Windows, start a free copy of NVDA.
  2. Open the editor.
  3. Tab to the list view button in the top toolbar and press enter.
  4. Notice how focus is placed in the left column.
  5. Try navigating up and down, everything should work fine.
  6. Try navigating to the right column. You will notice NVDA switches modes when it comes in contact with the options, button element.
@alexstine alexstine added [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Feature] List View Menu item in the top toolbar to select blocks from a list of links. [a11y] Keyboard & Focus labels Aug 31, 2022
@alexstine
Copy link
Contributor Author

@andrewserong I remember this was a horrible pain to implement, but you did a great job! Up to take on this challenge?

@andrewserong
Copy link
Contributor

Oh, this is a tricky one, thanks for the ping @alexstine! I'd love to help out with this, but unfortunately I'll be a bit busy these next couple of weeks as my priority at the moment is backporting changes to the Layout support for the 6.1 beta. Once those are sorted, I'm happy to have a go at this one if no-one beats me to it. Since it is a bug, we should be able to continue to work on it past the feature freeze for 6.1 if we don't have a fix in beforehand.

@alexstine
Copy link
Contributor Author

Something tells me probably no one will get to it before you @andrewserong , but you never know. Even if this does not make 6.1, this will lay the ground work for future development I would like to see happen.

Thanks.

@talldan
Copy link
Contributor

talldan commented Sep 20, 2022

@alexstine I tried a fix in #44291. Let me know what you think. I don't have a lot of experience with NVDA, so it's possible this may have other unwanted side effects, but I thought I'd try it out.

@talldan
Copy link
Contributor

talldan commented Sep 20, 2022

Another option is that we can completely remove the options dropdown menu from being part of the TreeGrid navigation and leave it with tabIndex=-1 so that it's not navigable. I imagine that would have similar results to aria-hidden.

@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants