Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various typography changes reset after moving paragraph block out of quote block #43491

Closed
annezazu opened this issue Aug 22, 2022 · 1 comment · Fixed by #45673
Closed

Various typography changes reset after moving paragraph block out of quote block #43491

annezazu opened this issue Aug 22, 2022 · 1 comment · Fixed by #45673
Assignees
Labels
[Block] Quote Affects the Quote Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] Drag and Drop Drag and drop functionality when working with blocks [Type] Bug An existing feature does not function as intended

Comments

@annezazu
Copy link
Contributor

annezazu commented Aug 22, 2022

Description

If you set some typography changes to a paragraph block, like font size or letter spacing, drag it into a quote block, and then drag it back out of the quote block, those changes are lost. This seems to happen with letter spacing and font size but not with letter case, appearance, or line height. I can't quite tell if this is a problem with the quote block, paragraph block, typography controls, drag and drop, etc.

This was found as part of the sixteenth call for testing for the FSE Outreach Program.

Step-by-step reproduction instructions

  1. Customize a paragraph block by changing font size or letter spacing.
  2. Drag it into a quote block (v2).
  3. Notice the changes remain.
  4. Drag the paragraph block outside of the quote block.
  5. Notice changes to font size and letter spacing are lost.

Screenshots, screen recording, code snippet

color.combo.+.losing.font.size.mov

Environment info

  • WordPress 6.0.1
  • Gutenberg 13.9
  • TT2

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@annezazu annezazu added [Type] Bug An existing feature does not function as intended [Feature] Drag and Drop Drag and drop functionality when working with blocks [Block] Quote Affects the Quote Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi labels Aug 22, 2022
@marko-srb
Copy link

I have also tested and it seems like two additional conclusions may help when looking into the issue:

  1. ‘Letter spacing’, ‘Size’, and ‘Drop cap’ are resetting to default and they aren’t shown when text is re-selected.
  2. The ‘Cmd+z’ shows that resetting of the text features happened outside of the ‘quote block’
    Check this video for clarification.

@aaronrobertshaw aaronrobertshaw self-assigned this Nov 9, 2022
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Nov 9, 2022
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Quote Affects the Quote Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] Drag and Drop Drag and drop functionality when working with blocks [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants