Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Logo Block: when set as Site Icon, W menu doesn't update #42943

Closed
annezazu opened this issue Aug 3, 2022 · 7 comments · Fixed by #42957
Closed

Site Logo Block: when set as Site Icon, W menu doesn't update #42943

annezazu opened this issue Aug 3, 2022 · 7 comments · Fixed by #42957
Assignees
Labels
[Block] Site Logo Affects the Site Logo Block [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") General Interface Parts of the UI which don't fall neatly under other labels. [Type] Bug An existing feature does not function as intended

Comments

@annezazu
Copy link
Contributor

annezazu commented Aug 3, 2022

Description

After updating to 13.8, when adding a site logo block, adding a logo, and setting it to "use as site icon" the W menu doesn't reflect the change. Instead, it continues to just show the WordPress logo. cc @priethor @Mamaduka

Step-by-step reproduction instructions

  1. Go to Appearance > Editor.
  2. Add a Site Logo block.
  3. Add a logo.
  4. In the block settings for the Site Logo block, toggle on the "Use as site icon" option.
  5. Notice that the site icon updates but the W menu/navigation component doesn't update.

Screenshots, screen recording, code snippet

Screen Shot 2022-08-03 at 11 41 47 AM

Environment info

  • WordPress 6.0.1
  • Gutenberg 13.8

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@annezazu annezazu added [Type] Bug An existing feature does not function as intended General Interface Parts of the UI which don't fall neatly under other labels. [Block] Site Logo Affects the Site Logo Block [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Aug 3, 2022
@Mamaduka
Copy link
Member

Mamaduka commented Aug 3, 2022

I can reproduce the same issue on 13.7, so probably not a new regression.

@Mamaduka Mamaduka self-assigned this Aug 4, 2022
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Aug 4, 2022
@carlomanf
Copy link

We discussed this in #38555 and #38575 and discovered that this same issue occurred when the Gutenberg plugin was inactive. Can someone confirm whether the work here has any impact on that?

@Mamaduka
Copy link
Member

Mamaduka commented Aug 4, 2022

@carlomanf, the issue exists in WP 6.0 as well. This change needs to be backported into the core for a fix.

@carlomanf
Copy link

We were finding the issue in version 5.9 actually. Just want to verify if that is also your understanding?

@annezazu
Copy link
Contributor Author

@gziolo want to flag this as consideration for 6.0.2. @carlomanf curious to hear more about what you were/are seeing with 5.9?

@carlomanf
Copy link

@annezazu According to #38575 (comment) the site icon failed to show up in core version 5.9 if the gutenberg plugin was inactive, and only showed up if the gutenberg plugin was active. Not sure of the behaviour pre-5.9.

@gziolo gziolo added Backport to WP Minor Release Pull request that needs to be backported to a WordPress minor release and removed Backport to WP Minor Release Pull request that needs to be backported to a WordPress minor release labels Aug 11, 2022
@annezazu
Copy link
Contributor Author

Ah thank you! This should make it into 6.0.2 so hopefully we can get this fixed once and for all :)

@gziolo gziolo moved this from Triage to Done in WordPress 6.0.x Editor Tasks Aug 22, 2022
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Site Logo Affects the Site Logo Block [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") General Interface Parts of the UI which don't fall neatly under other labels. [Type] Bug An existing feature does not function as intended
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants