Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template names for specific entities can get confusing when the entity is renamed #42894

Closed
jameskoster opened this issue Aug 2, 2022 · 5 comments · Fixed by #43862
Closed
Assignees
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Technical Feedback Needs testing from a developer perspective. [Type] Enhancement A suggestion for improvement.

Comments

@jameskoster
Copy link
Contributor

This came up in #42165.

When you create a template for a specific entity, its name is used to define the template name. For example if you create a template for your post 'Hello World!' the template will be named 'Post: Hello World!'.

If you change the title of that post, the template name is not updated to match. This can make identifying templates difficult over time.

Let's discuss ways we can make the names for these templates dynamic, so that they update in lock-step with the source entity.

cc @jorgefilipecosta @ntsekouras

@jameskoster jameskoster added [Type] Enhancement A suggestion for improvement. [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Aug 2, 2022
@mcsf
Copy link
Contributor

mcsf commented Aug 18, 2022

Could this become a blocker for 6.1 if not addressed? @mtias @priethor

@jorgefilipecosta
Copy link
Member

I think the simple fix would be not to store hard-coded names on the template name and description and instead leave them empty. If they are empty, the rest endpoint would dynamically compute names and descriptions based on the entities being referenced.
I think ideally, this would be addressed before 6.1 otherwise, on 6.1 we are going to store names and then even if we fix we still have confusing names for things already stored.

@priethor
Copy link
Contributor

priethor commented Sep 1, 2022

I think ideally, this would be addressed before 6.1 otherwise

Agreed, I don't think it's a blocker, but it would definitely be terrific to address it before 6.1

@jameskoster
Copy link
Contributor Author

Yeah it would be nice to eliminate any backwards compatibility headaches if we can 🙏

@jorgefilipecosta
Copy link
Member

PR to fix this issue available at #43862.

@mtias mtias added the Needs Technical Feedback Needs testing from a developer perspective. label Sep 10, 2022
@glendaviesnz glendaviesnz moved this from Triage to In Progress in WordPress 6.1 Editor Tasks Sep 19, 2022
Repository owner moved this from In Progress to Done in WordPress 6.1 Editor Tasks Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Technical Feedback Needs testing from a developer perspective. [Type] Enhancement A suggestion for improvement.
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

5 participants