Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reusable blocks don't allow editing of HTML #4204

Closed
karmatosed opened this issue Dec 29, 2017 · 1 comment
Closed

Reusable blocks don't allow editing of HTML #4204

karmatosed opened this issue Dec 29, 2017 · 1 comment
Labels
[Feature] Blocks Overall functionality of blocks [Type] Bug An existing feature does not function as intended

Comments

@karmatosed
Copy link
Member

If you click to edit HTML on a reusable block you get this:

issue-edithtml-reusableblock

I would suggest we just disable this functionality if it's unable to be used. Ideally we would be able to edit HTML on a reusable block. Maybe if we can only do that when in 'edit mode' of a reusable block, we disable when not in that state?
@karmatosed karmatosed added [Feature] Blocks Overall functionality of blocks [Type] Bug An existing feature does not function as intended labels Dec 29, 2017
@mtias
Copy link
Member

mtias commented Jan 1, 2018

I thought we had already disabled this. It's just a flag on the block registration.

@mtias mtias mentioned this issue Jan 3, 2018
Merged
@karmatosed karmatosed mentioned this issue Jan 4, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Blocks Overall functionality of blocks [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@karmatosed @mtias